wsme is not correctly requiring simplegeneric

[John L. Villalovos]

2015-05-27T23:39:42 <jlvillal> dhellmann, fungi, So reverting that simplegeneric patch failed the testing: https://review.openstack.org/#/c/186208/
2015-05-27T23:40:25 <jlvillal> dhellmann, fungi, http://logs.openstack.org/08/186208/1/check/gate-ironic-python34/b3618cd/
2015-05-27T23:41:00 <fungi> jlvillal: thanks. seeing now if i can interpret why
2015-05-27T23:43:29 <jlvillal> fungi, Thanks
2015-05-27T23:46:25 <fungi> dhellmann: jlvillal: it looks like wsme 0.6.4 is installed according to tox/py34-1.log and while it has simplegeneric in the install_requires within its setup.py that doesn't seem to get pulled in
2015-05-27T23:46:53 <jlvillal> fungi, Yes, I think that is what we were seeing. And why they put in the change to tox.ini
2015-05-27T23:47:05 <jlvillal> fungi, Why it isn't being pulled in, not sure....
2015-05-27T23:47:20 <lifeless> install_requires in setup.py? Is it a pbr using project?
2015-05-27T23:47:29 <fungi> lifeless: as of 0.6.4 it was not, no
2015-05-27T23:47:31 <lifeless> pbr sets install_requires from static data, setup.py's values will be ignored.
2015-05-27T23:47:45 <fungi> lifeless: no, wait it was indeed using pbr at that point
2015-05-27T23:47:52 <fungi> lifeless: http://git.openstack.org/cgit/stackforge/wsme/tree/setup.py?id=0.6.4 for reference
2015-05-27T23:48:06 <fungi> lifeless: so perhaps new-world pbr has broken that
2015-05-27T23:51:19 <lifeless> fungi: I don't think it ever worked
2015-05-27T23:51:32 <lifeless> fungi: we assign to the setup.py kwargs in utils.py
2015-05-27T23:51:33 <fungi> lifeless: dhellmann: jlvillal: so i wonder if tagging a wsme 0.7 is in order?
2015-05-27T23:52:00 <fungi> it looks much more pbresque
2015-05-27T23:52:07 <fungi> master does, i mean
2015-05-27T23:52:30 <fungi> 0.6.4 was ~6mos ago
2015-05-27T23:53:07 <fungi> it's going on 25 changes since then
2015-05-27T23:53:55 <lifeless> actually no, yes I'm sure pbr regressed this - but we never claimed to support it (and never had tests) - and update.py enforces a standard setup.py
2015-05-27T23:54:14 <lifeless> so while we might want to fix it (please file a bug), we should fix wsme IMO
2015-05-27T23:54:14 <dhellmann> lifeless: wsme isn't an openstack project, it's just trying to use some of the same tools
2015-05-27T23:54:20 <dhellmann> yeah, I agree
2015-05-27T23:54:48 <dhellmann> fungi, lifeless, jlvillal: how about if I make a note to release wsme on monday? do we think the current master fixes this?
2015-05-27T23:55:16 <fungi> dhellmann: it looks like it should. though who knows what new shadows lurk in the heart of 0.7.0
2015-05-27T23:55:23 <jlvillal> fungi, dhellmann, if a new wsme fixes it then sounds good to me :)
2015-05-27T23:55:30 <dhellmann> fungi: right, so no releases this late in the week :-)
2015-05-27T23:55:57 <fungi> jlvillal: yeah, i guess keep your workaround in place and recheck 186208 once that happens
2015-05-27T23:56:09 <jlvillal> fungi, Okay.
2015-05-27T23:56:35 <dhellmann> jlvillal: do you have a bug open for this?
2015-05-27T23:56:48 <fungi> jlvillal: and if it passes, then update the commit message with some better detail about the wsme release and get it merged
2015-05-27T23:57:35 <fungi> dhellmann: the change that added the workaround in ironic said a bug report was desired, but it was also during the summit so...
2015-05-27T23:57:46 <dhellmann> fungi: yeah
2015-05-27T23:57:58 <dhellmann> jlvillal: please file a bug against wsme so we have something to track this with

[Stéphane Bisinger (kjir)]

simplegeneric is in the requirements-py3.txt and since we introduced unit tests for python 3.4 we can be pretty confident that the dependency is pulled in correctly.

I think a 0.7.0 release is due, since there are a lot of important bugfixes included.

[John L. Villalovos (happycamp)]

Stephane,

There seems to be a bug in the current released version with Python 3.4.

Failure log showing simplegeneric is not found:

http://logs.openstack.org/08/186208/1/check/gate-ironic-python34/b3618cd/console.html

From this patch:
https://review.openstack.org/#/c/186208/

[Stéphane Bisinger (kjir)]

Looks like it is working correctly on the master branch: http://paste.openstack.org/show/243158/
This means that with a new release this bug can be closed!

Also I verified that installing WSME from PyPI doesn't pull in *ANY* dependency, so I find it surprising that nobody ever complained about it.

I believe a new release is really needed...

[John L. Villalovos (happycamp)]

I think the plan is to do a new release on Monday. Too late in the week to do it now.

[Lucas Alvares Gomes (lucasagomes)]

Ok since the problem is fixed in the master branch we can mark this bug as "Fix committed" and after the release we can tag as "Fix released"