Juniper Openstack

Improve end to end handling of bgp update encode errors

Bug #1459401 reported by Nischal Sheth on 2015-05-27

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Juniper Openstack	Status tracked in Trunk
R2.0	Fix Committed	High	Nischal Sheth	Juniper Openstack r2.20-fcs
R2.1	Fix Committed	High	Nischal Sheth	Juniper Openstack r2.11 "r2.11"
R2.20	Fix Committed	High	Nischal Sheth	Juniper Openstack r2.02
Trunk	Fix Committed	High	Nischal Sheth	Juniper Openstack r3.0-fcs

Bug Description

Existing code may send malformed/empty messages. Need to
improve end to end handling of bgp update encode errors.

See original description

Tags:

Nischal Sheth (nsheth) on 2015-05-27

description:

updated

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-27: master

Review in progress for https://review.opencontrail.org/10938
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-27: R2.20

Review in progress for https://review.opencontrail.org/10939
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-27: R2.1

Review in progress for https://review.opencontrail.org/10943
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-28: R2.0

Review in progress for https://review.opencontrail.org/10964
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-28: master

Review in progress for https://review.opencontrail.org/10938
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-28: R2.20

Review in progress for https://review.opencontrail.org/10939
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-28: R2.1

Review in progress for https://review.opencontrail.org/10943
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-28: R2.0

#11

Review in progress for https://review.opencontrail.org/10964
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-29: A change has been merged

#13

Reviewed: https://review.opencontrail.org/10939
Committed: http://github.org/Juniper/contrail-controller/commit/1158b24b84105d3f330bd8829c4d72be82613245
Submitter: Zuul
Branch: R2.20

commit 1158b24b84105d3f330bd8829c4d72be82613245
Author: Nischal Sheth <email address hidden>
Date: Tue May 26 21:45:19 2015 -0700

Handle error where generated bgp update is too big

Change-Id: Ifceb9987aa1f49c77c23365030d0e7713730c052
Closes-Bug: 1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-29:

#14

Reviewed: https://review.opencontrail.org/10938
Committed: http://github.org/Juniper/contrail-controller/commit/339d30be165c5bb8431f2dea19039c7d8d736fe5
Submitter: Zuul
Branch: master

commit 339d30be165c5bb8431f2dea19039c7d8d736fe5
Author: Nischal Sheth <email address hidden>
Date: Tue May 26 21:45:19 2015 -0700

Handle error where generated bgp update is too big

Change-Id: Ifceb9987aa1f49c77c23365030d0e7713730c052
Closes-Bug: 1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-30:

#15

Reviewed: https://review.opencontrail.org/10943
Committed: http://github.org/Juniper/contrail-controller/commit/90b6cbd6268cf72f62466acc1ef354cac58e7eab
Submitter: Zuul
Branch: R2.1

commit 90b6cbd6268cf72f62466acc1ef354cac58e7eab
Author: Nischal Sheth <email address hidden>
Date: Tue May 26 21:45:19 2015 -0700

Handle error where generated bgp update is too big

Change-Id: Ifceb9987aa1f49c77c23365030d0e7713730c052
Closes-Bug: 1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-05-30:

#16

Reviewed: https://review.opencontrail.org/10964
Committed: http://github.org/Juniper/contrail-controller/commit/32d044209a7cf47261dd46f1752919b428cd2f31
Submitter: Zuul
Branch: R2.0

commit 32d044209a7cf47261dd46f1752919b428cd2f31
Author: Nischal Sheth <email address hidden>
Date: Tue May 26 21:45:19 2015 -0700

Handle error where generated bgp update is too big

Change-Id: Ifceb9987aa1f49c77c23365030d0e7713730c052
Closes-Bug: 1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01: master

#17

Review in progress for https://review.opencontrail.org/11090
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01: R2.20

#20

Review in progress for https://review.opencontrail.org/11091
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01: R2.1

#22

Review in progress for https://review.opencontrail.org/11092
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01: R2.0

#24

Review in progress for https://review.opencontrail.org/11093
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01: A change has been merged

#26

Reviewed: https://review.opencontrail.org/11092
Committed: http://github.org/Juniper/contrail-controller/commit/4e2790570e199be0178bdeb9696b1a083ff828de
Submitter: Zuul
Branch: R2.1

commit 4e2790570e199be0178bdeb9696b1a083ff828de
Author: Nischal Sheth <email address hidden>
Date: Sun May 31 22:13:31 2015 -0700

Make BgpServer:message_build_error_ atomic and initialize it to 0

Change-Id: Iabebe10df0f6dcb0b701bedcccdb2d4e25065de0
Closes-Bug: #1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01:

#27

Reviewed: https://review.opencontrail.org/11091
Committed: http://github.org/Juniper/contrail-controller/commit/1392e51499dbdf9aa596f0e51ca3d6fc7aaf15e5
Submitter: Zuul
Branch: R2.20

commit 1392e51499dbdf9aa596f0e51ca3d6fc7aaf15e5
Author: Nischal Sheth <email address hidden>
Date: Sun May 31 22:13:31 2015 -0700

Make BgpServer:message_build_error_ atomic and initialize it to 0

Change-Id: Iabebe10df0f6dcb0b701bedcccdb2d4e25065de0
Closes-Bug: #1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01:

#28

Reviewed: https://review.opencontrail.org/11093
Committed: http://github.org/Juniper/contrail-controller/commit/ef9e34a5531662694c9961512c17aa89c2f7b5e7
Submitter: Zuul
Branch: R2.0

commit ef9e34a5531662694c9961512c17aa89c2f7b5e7
Author: Nischal Sheth <email address hidden>
Date: Sun May 31 22:13:31 2015 -0700

Make BgpServer:message_build_error_ atomic and initialize it to 0

Change-Id: Iabebe10df0f6dcb0b701bedcccdb2d4e25065de0
Closes-Bug: #1459401

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2015-06-01:

#29

Reviewed: https://review.opencontrail.org/11090
Committed: http://github.org/Juniper/contrail-controller/commit/afd2c7084ac6c41d9fb0a3d0f48c4da0dba882f7
Submitter: Zuul
Branch: master

commit afd2c7084ac6c41d9fb0a3d0f48c4da0dba882f7
Author: Nischal Sheth <email address hidden>
Date: Sun May 31 22:13:31 2015 -0700

Make BgpServer:message_build_error_ atomic and initialize it to 0

Change-Id: Iabebe10df0f6dcb0b701bedcccdb2d4e25065de0
Closes-Bug: #1459401

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.