test_backupagent.py contains unmocked entry

Bug #1459206 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Sushil Kumar

Bug Description

Changed in trove:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/185941

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
Amrith Kumar (amrith) wrote :

I'm hoping that all of these similar bugs can be fixed in a single commit, rather than one commit per bug. Likewise, having a bug per unmocked entry seems a tad excessive.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/185941
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=53e7ea9d7293f047ebc87b02a6d9266a5351e25c
Submitter: Jenkins
Branch: master

commit 53e7ea9d7293f047ebc87b02a6d9266a5351e25c
Author: Sushil Kumar <email address hidden>
Date: Wed May 27 11:46:02 2015 +0000

    Fixes the unsafe global mocks

    It was found during some earlier reviews the following modules
    had global mocks which needed to be fixed:

    - trove/tests/unittests/backup/test_backup_models.py
    - trove/tests/unittests/backup/test_backupagent.py
    - trove/tests/unittests/instance/test_instance_models.py

    Fixed these global unmocked and unsafe mocked entries.

    While fixing these entries found that some tests were passing
    because of these leaked mocks in following modules,
    resolved those tests, too:
    - trove/tests/unittests/taskmanager/test_api.py
    - trove/tests/unittests/taskmanager/test_vertica_clusters.py

    Change-Id: Ifcd11ea7e4dce25b927ec2e2eea0bae0251c2a8f
    Closes-Bug: #1459205
    Closes-Bug: #1459206
    Closes-Bug: #1459207

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: none → liberty-1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-1 → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.