Improve k8s manifest validation

Bug #1458879 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Ronald Bradford

Bug Description

When parsing k8s manifest, an exception should be raised if the inputted manifest is blank. Please see Tom's comment in the review below:

https://review.openstack.org/#/c/185454/1/magnum/tests/unit/common/test_k8s_manifest.py

Tags: tech-debt
hongbin (hongbin034)
tags: added: tech-debt
Changed in magnum:
assignee: nobody → Ronald Bradford (ronaldbradford)
Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/185454
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=d3e041b785f9e4a2bd2bd2714d938c7afb8ab3c5
Submitter: Jenkins
Branch: master

commit d3e041b785f9e4a2bd2bd2714d938c7afb8ab3c5
Author: Ronald Bradford <email address hidden>
Date: Mon May 25 17:19:28 2015 -0400

    Improving Unit Test coverage of k8s_manifest

    In addition these tests are used to provide a documented example
    to demonstrate writing unit tests for new contributors for
    increasing project code coverage.

    Change-Id: I8448bf9ea050513dfb271cdce7f61d37f89fd186
    Closes-Bug: #1458879
    Partially-Implements: blueprint integrate-ci-metrics

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.