No hostname validation

Bug #1458800 reported by Marcos Lobo
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
In Progress
Wishlist
Marcos Lobo

Bug Description

Horizon Juno does not have hostname validation in instance creation form. For example, you can create a new instance with name: "#3rtttt"

That name will cause problems when Nova try to handle, but Horizon allow launch a new instance with a not valid hostname. A valid hostname is specified in RFC1123 (http://tools.ietf.org/html/rfc1123).

I propose add hostname validation to create/edit instance form following the RFC1123.

Changed in horizon:
assignee: nobody → Ritesh (rsritesh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/185904

Changed in horizon:
assignee: Ritesh (rsritesh) → Marcos Lobo (marcos-fermin-lobo)
status: New → In Progress
Revision history for this message
Ritesh Paiboina (rsritesh) wrote :

This is wrong way of doing work. You cannot remove as assignee like.. If I have assigned myself, it means that I am doing to fix that.
If you have fix, at least you can tell here that you have got a fix and you are going to submit.

Revision history for this message
Marcos Lobo (marcos-fermin-lobo) wrote :

Ritesh, I guess all of us (open source community) can participate and collaborate in this patch, no problem for me if you want modify the patch and/or finish it ;)

Revision history for this message
Marcos Lobo (marcos-fermin-lobo) wrote :

I was thinking about activate/deactivate this validation through via settings parameter... Any comments?

Changed in horizon:
assignee: Marcos Lobo (marcos-fermin-lobo) → zouyee (zoues)
Changed in horizon:
assignee: zouyee (zoues) → Marcos Lobo (marcos-fermin-lobo)
Changed in horizon:
assignee: Marcos Lobo (marcos-fermin-lobo) → nobody
importance: Undecided → Wishlist
status: In Progress → Confirmed
milestone: none → next
Changed in horizon:
assignee: nobody → Marcos Lobo (marcos-fermin-lobo)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/185904
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.