[Fuel CLI] Unclear deprecation warning

[Mike Scherbakov]

[root@nailgun ~]# fuel node
DEPRECATION WARNING: /etc/fuel/client/config.yaml exists and will be used as the source for settings. This behavior is deprecated. Please specify the path to your custom settings file in the FUELCLIENT_CUSTOM_SETTINGS environment variable.

The message above doesn't provide very clear answer on how user should behave. Namely, "Please specify the path to your custom settings file in the FUELCLIENT_CUSTOM_SETTINGS environment variable." is not explanatory enough. Is there a template of new config file I could use? Where new config file is going to be located? Or should I use command line options instead?

Please provide more clear message and new config file template if needed.

[Sebastian Kalinowski (prmtl)]

This not only an issue with unclear deprecation message but also a problem with lack of fuelclient specific documentation.

[Timur Nurlygayanov (tnurlygayanov)]

I really want to fix it in MOS 6.1 because this warning looks really weird.

[Nastya Urlapova (aurlapova)]

Timur, this issue is not High, according HCF rules it was moved to 7.0. Thank you!

[Baboune (seyvet)]

In the meantime, how to remove the warning? What the actions needed?

[Vladimir Sharshov (vsharshov)]

known-issue. Does not affect deployment. Moving to 8.0

[Andrew Woodward (xarses)]

Guys, why do we keep punting this, the message is annoying and confusing. What is necessary to stop this from occurring?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/215077

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/215115

[Timur Nurlygayanov (tnurlygayanov)]

Fixed in two repositories:

https://review.openstack.org/215077
https://review.openstack.org/215115

[Timur Nurlygayanov (tnurlygayanov)]

The final fix with new configuration file is available by the following link:
https://review.openstack.org/#/c/215115

We are going to review this commit and merge it for MOS 7.0. And looks like it will be not actual for MOS 8.0

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timur Nurlygayanov (<email address hidden>) on branch: master
Review: https://review.openstack.org/215077
Reason: This issue will be fixed for MOS 7.0 in the following commit:
https://review.openstack.org/#/c/215115

For MOS 8.0+ we need to implement new fuelclient which will have no such issues.

[Timur Nurlygayanov (tnurlygayanov)]

The final fix with new configuration file is available by the following link:
https://review.openstack.org/#/c/215115

We are going to review this commit and merge it for MOS 7.0. And looks like it will be not actual for MOS 8.0

[Timur Nurlygayanov (tnurlygayanov)]

fix for MOS 7.0 stable branch:
https://review.openstack.org/222118

[Olga Gusarenko (ogusarenko)]

Guys, could you clarify what exactly should be added to the Release Notes 7.0. Unfortunately I cannot get it from the bug description.

Will the fix for MOS 7.0 be merged? And if not what is the workaround for this?

Thanks in advance!

[Timur Nurlygayanov (tnurlygayanov)]

Hi Olga,
we are going to merge fix in MOS 7.0 updates (and it will be not in MOS 7.0 GA, only in updates).

the bug in the following:
we have updated fuel CLI client but didn't update the configuration file for it. In the result every time when user will use CLI tool 'fuel' on master node he will see the warning message in console:

DEPRECATION WARNING: /etc/fuel/client/config.yaml exists and will be used as the source for settings. This behavior is deprecated. Please specify the path to your custom settings file in the FUELCLIENT_CUSTOM_SETTINGS environment variable.

The workaround is available and it is simple:
Need to just remove file with old configuration: 'rm -rf /etc/fuel/client/config.yaml '

[Olga Gusarenko (ogusarenko)]

Timur, thank you much for the explanation. It is very helpful!

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/224052

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224052
Committed: https://git.openstack.org/cgit/stackforge/fuel-docs/commit/?id=2a6f32612833afa6aac5a0e6012bd304829c55c2
Submitter: Jenkins
Branch: master

commit 2a6f32612833afa6aac5a0e6012bd304829c55c2
Author: OlgaGusarenko <email address hidden>
Date: Wed Sep 16 15:16:54 2015 +0300

    [RN 7.0] Deprecation warning in fuel client

    Adds the workaround for LP1458361

    Change-Id: Ib1a9b8e4228b187f37bc1ff991f281874c5f1fc4
    Related-Bug: #1458361

[Vitaly Sedelnik (vsedelnik)]

Nominated for 7.0-mu-1, Timur - please work with reviewers to ensure the change is ready to merge, thanks!

[Timur Nurlygayanov (tnurlygayanov)]

Ok, will do.

[Vitaly Sedelnik (vsedelnik)]

Confirmed for 7.0 MU 1 per conversation with Timur in person

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235171

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timur Nurlygayanov (<email address hidden>) on branch: master
Review: https://review.openstack.org/215115
Reason: ok, Roman, thank you for the fix!

But let's merge fix for 7.0 branch as is.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235171
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=1ad9bacd650e665989d4eb58011ea2a788efe690
Submitter: Jenkins
Branch: master

commit 1ad9bacd650e665989d4eb58011ea2a788efe690
Author: Roman Prykhodchenko <email address hidden>
Date: Thu Oct 15 12:10:48 2015 +0200

    Generate user settings file

    Since relying on a system-wide /etc/... configuration
    file is not a good approach for a user-side application
    it's necessary to not use that file by default.

    This patch changes default settings file to ~/.config/fuel/fuel_client.yaml
    and adds generation of one with default values if it does not exist.
    Specifying of a custom settings file using FUELCLIENT_CUSTOM_SETTINGS
    variable is still possible.

    DocImpact
    Closes-bug: #1458361
    Change-Id: Ia17c8edbdd71a74318d3237a47d4b5650934c378

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/237982

[Roman Prykhodchenko (romcheg)]

Since the fix involves dropping backwards compatibility with older versions, it cannot be backported.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timur Nurlygayanov (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/222118

[Anastasia Palkina (apalkina)]

Verified on ISO #91

"fuel-createmirror_sha": "6e1b82b2059a20f1fa9a4d794b976edaad156b85", "shotgun_sha": "bbbfccff9eb90895b13fae3fac398e65efe646f4", "api": "1.0", "fuelmain_sha": "058e07386350bfa0a8365818cf75893949e0d863", "astute_sha": "cfd5d6b916a17ad2f73e6c567a0365845155b0e3", "fuel-ostf_sha": "1ab201cb8c3bba04522bf56ce72e863a03ff09b3", "openstack_version": "2015.1.0-8.0", "build_id": "91", "fuelmenu_sha": "e68335c88feca803c97d75ae5a6e7de1e3f330dc", "build_number": "91", "auth_required": true, "fuel-library_sha": "679c1a3f15e6c32309f2c4996aea4672b28daa1a", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "a1afcf0d0de61197c4a14aa014583583daa05836", "fuel-agent_sha": "d2103bee6e216396eb8e308ec5448328c9ee4261", "production": "docker", "python-fuelclient_sha": "2a1b048cc439986e222ece43a290b5cc68e92a77", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "6e1b82b2059a20f1fa9a4d794b976edaad156b85", "shotgun_sha": "bbbfccff9eb90895b13fae3fac398e65efe646f4", "api": "1.0", "fuelmain_sha": "058e07386350bfa0a8365818cf75893949e0d863", "astute_sha": "cfd5d6b916a17ad2f73e6c567a0365845155b0e3", "fuel-ostf_sha": "1ab201cb8c3bba04522bf56ce72e863a03ff09b3", "openstack_version": "2015.1.0-8.0", "build_id": "91", "fuelmenu_sha": "e68335c88feca803c97d75ae5a6e7de1e3f330dc", "build_number": "91", "fuel-library_sha": "679c1a3f15e6c32309f2c4996aea4672b28daa1a", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "a1afcf0d0de61197c4a14aa014583583daa05836", "fuel-agent_sha": "d2103bee6e216396eb8e308ec5448328c9ee4261", "production": "docker", "python-fuelclient_sha": "2a1b048cc439986e222ece43a290b5cc68e92a77", "feature_groups": ["mirantis"], "release": "8.0"}}}

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/215115
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f68bf3260cd49a0e0a60ff1eb325ddf940cba091
Submitter: Jenkins
Branch: master

commit f68bf3260cd49a0e0a60ff1eb325ddf940cba091
Author: Timur Nurlygayanov <email address hidden>
Date: Thu Sep 10 13:17:07 2015 +0300

    Put fuelclient configuration file in root's $HOME

    System-wide fuelclient configuration has been deprecated.

    Related-Bug: 1458361
    Co-authored-by: Sergii Golovatiuk <email address hidden>
    Co-authored-by: Bartłomiej Piotrowski <email address hidden>
    Depends-on: Ia17c8edbdd71a74318d3237a47d4b5650934c378
    Change-Id: I08fd7bf965af1552d16671636c4f706c5a2d6a11

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/237982
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=6faf3e6540268914e1853895210ce7441770838e
Submitter: Jenkins
Branch: master

commit 6faf3e6540268914e1853895210ce7441770838e
Author: Roman Prykhodchenko <email address hidden>
Date: Wed Oct 21 12:44:46 2015 +0200

    Don't use /etc/fuel/client.yaml

    This patch removes usage of the old default
    settings file. Users must use user-side configuration
    file that is generated to $XDG_CONFIG_COME.

    Related-Bug: #1458361
    Change-Id: Ie2defd31c7ddc205fec3f0fcc864990098e37fb1