engine.connectionControl(group, control, function, true) connects control to a function rather than removes connection

[Be]

According to http://mixxx.org/wiki/doku.php/midi_scripting#automatic_reactions , "engine.connectControl(control group, control name, script function name, true) - Tacking a ,true on to the list of parameters disconnects the specified Mixxx control signal from the specified script function. It returns true if the disconnection was successful." However, this makes a new connection rather than disconnecting. I tried commenting out every instance of engine.connectControl() in my script and put one in the init function with true as the last argument and the function executed when that control was changed. Wrapping engine.connectControl() in an if statement that prints a debug message shows that engine.connectControl() returns true whether or not the the last boolean argument is included (regardless of whether it is true or false).

[Be (be.ing)]

This happens both with 1.12 beta and 1.11.

[Sébastien BLAISOT (sblaisot)]

I tried to reproduce it with attached testing mapping with no luck.

adding true as a last argument did disconnect the control for me.

[Be (be.ing)]

Your example works as expected. I figured out what I was doing differently in my script. I was not putting the function names (the third argument) in quotes. It is weird that the connection works without quotes but not the disconnection.

Curiously, I get these errors in the debugging output:
Warning [Controller]: Could not Disconnect connection "testit.button1"
but it actually does disconnect the function.

Thanks for taking the time to make that example and test it.

[Be (be.ing)]

Err, the debug message is actually:
Warning [Controller]: Could not Disconnect connection "testit.playLed"

[Be (be.ing)]

I made a note of this on the wiki and corrected the deck toggle button example.

[Sébastien BLAISOT (sblaisot)]

In fact, there is a bug in code :
https://github.com/mixxxdj/mixxx/blob/1.12/src/controllers/controllerengine.cpp#L801

if "callback" parameter is a string, the "disconnect" parameter is taken into account, but if "callback" is a function or a QObject, the "disconnect" parameter is totally ignored.

I think we should handle the "disconnect" parameter should be respected even if the callback parameter is a function.

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/pull/656

[Be (be.ing)]

https://github.com/mixxxdj/mixxx/commit/17de684e40d718730f221fff63034ee68082466a

[Be (be.ing)]

Actual fix for this was to deprecate the messy, inconsistent API of engine.connectControl in favor of engine.makeConnection https://github.com/mixxxdj/mixxx/pull/1218

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8062