fix controller worker pool delete

[Brandon Logan]

the pool delete method and flow has some various issues that cause errors. These need to be fixed and tests updated/added.

[Brandon Logan (brandon-logan)]

2015-06-01 17:54:52.576 31962 ERROR oslo_messaging.rpc.dispatcher [-] Exception during message handling: 'taskflow.patterns.linear_flow.Flow: octavia-delete-pool-flow; 4' requires ['loadbalancer'] but no other entity produces said requirements
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher Traceback (most recent call last):
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher executor_callback))
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 186, in _dispatch
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher executor_callback)
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 130, in _do_dispatch
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher result = func(ctxt, **new_args)
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/octavia/octavia/controller/queue/endpoint.py", line 72, in delete_pool
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher self.worker.delete_pool(pool_id)
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/octavia/octavia/controller/worker/controller_worker.py", line 429, in delete_pool
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher 'vip': vip})
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/octavia/octavia/common/base_taskflow.py", line 43, in _taskflow_load
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher eng.prepare()
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/taskflow/utils/lock_utils.py", line 89, in wrapper
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher return f(self, *args, **kwargs)
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/taskflow/engines/action_engine/engine.py", line 196, in prepare
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher raise exc.MissingDependencies(self._flow, sorted(missing))
2015-06-01 17:54:52.576 31962 TRACE oslo_messaging.rpc.dispatcher MissingDependencies: 'taskflow.patterns.linear_flow.Flow: octavia-delete-pool-flow; 4' requires ['loadbalancer'] but no other entity produces said requirements

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/190780

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/190780
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=00640a9c6ff0e24d9f61e0767083b97e3b94c607
Submitter: Jenkins
Branch: master

commit 00640a9c6ff0e24d9f61e0767083b97e3b94c607
Author: Trevor Vardeman <email address hidden>
Date: Thu Jun 11 14:25:28 2015 -0500

    Fix the delete pool flow

    Updated tasks in delete flow
    Added more constants to keep flows consistent
    Updated model methods to define a deletion step
    Updated unit tests

    Change-Id: Icf22c36cbdf0e3f95b56876c776524958090bdf2
    Closes-Bug: 1458242