Pure Storage driver needs to return snapshot objects for create_cgsnapshot and delete_cgsnapshot

Bug #1458126 reported by Thang Pham
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Patrick East

Bug Description

This bug is a placeholder to have Pure Storage driver return snapshot objects instead of snapshot dictionaries for create_cgsnapshot and delete_cgsnapshot methods. It was noted on a review comment in https://review.openstack.org/#/c/163910/14//COMMIT_MSG. This can be done be replacing occurences of db.snapshot_get_all_for_cgsnapshot() to SnapshotList.get_all_for_cgsnapshot() in create_cgsnapshot and delete_cgsnapshot. It is dependent on https://review.openstack.org/#/c/163910/.

Changed in cinder:
assignee: nobody → Patrick East (patrick-east)
Xing Yang (xing-yang)
Changed in cinder:
status: New → Triaged
importance: Undecided → Medium
Thang Pham (thang-pham)
description: updated
Thang Pham (thang-pham)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/211802

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/211802
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=863d3456c6a4667d68f27ebb759f1adbf8f6f3ea
Submitter: Jenkins
Branch: master

commit 863d3456c6a4667d68f27ebb759f1adbf8f6f3ea
Author: Patrick East <email address hidden>
Date: Tue Aug 11 14:48:51 2015 -0700

    Switch Pure volume drivers to use Snapshot Objects

    Some consistency group operations require looking up snapshot objects
    and returning them. Now that we have Snapshot objects we should be using
    those.

    Change-Id: Ib4ff7fa3f7d768abb33e3b9436f7e64a3cd81f4c
    Closes-Bug: #1458126

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.