Bug #1457794 “[granular-deployment] No possibility to control re...” : Bugs : Fuel for OpenStack

Veronica Krayneva (vkrayneva) on 2015-05-22

Changed in fuel:
importance:	Undecided → Wishlist

Vladimir Sharshov (vsharshov) on 2015-05-22

Changed in fuel:
assignee:	nobody → Fuel Python Team (fuel-python)
milestone:	none → 7.0
status:	New → Confirmed
tags:	added: granular
tags:	added: feature

Dmitry Pyzhov (dpyzhov) on 2015-08-03

Changed in fuel:
milestone:	7.0 → 8.0

Sebastian Kalinowski (prmtl) on 2015-09-08

Changed in fuel:
assignee:	Fuel Python Team (fuel-python) → Sebastian Kalinowski (prmtl)

Sebastian Kalinowski (prmtl) on 2015-09-08

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-09: Fix proposed to fuel-astute (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/221729

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-10: Fix proposed to fuel-plugins (master)

#2

Fix proposed to branch: master
Review: https://review.openstack.org/222149

OpenStack Infra (hudson-openstack) on 2015-09-15

Changed in fuel:
assignee:	Sebastian Kalinowski (prmtl) → Igor Kalnitsky (ikalnitsky)

Ihor Kalnytskyi (ikalnytskyi) on 2015-09-15

Changed in fuel:
assignee:	Igor Kalnitsky (ikalnitsky) → Sebastian Kalinowski (prmtl)

Alexey Shtokolov (ashtokolov) on 2015-09-18

Changed in fuel:
importance:	Wishlist → Low

slava valyavskiy (slava-val-al) on 2015-09-18

tags:	added: customer-found
Changed in fuel:
importance:	Low → High

Revision history for this message

Andrey Maximov (maximov) wrote on 2015-09-22:

#3

Moving out of 7.0 because of HCF

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-22: Fix merged to fuel-astute (master)

#4

Reviewed: https://review.openstack.org/221729
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=d89ea8c3c6d91e3c5151534f4145b50c45b25d13
Submitter: Jenkins
Branch: master

commit d89ea8c3c6d91e3c5151534f4145b50c45b25d13
Author: Sebastian Kalinowski <email address hidden>
Date: Wed Sep 9 13:36:31 2015 +0200

Allow to specify number of retries for puppet task

    Now it's possible to specify a number of retries for
    puppet task in granural deployment by specifying a new
    parameter "retries":

      parameters:
        ...
        retries: 10

By default, there are 2 retries.

Change-Id: I819a019cf488fc1bd0d52b35d1693fcc088125cb
Partial-Bug: #1457794

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-28: Fix merged to fuel-plugins (master)

#5

Reviewed: https://review.openstack.org/222149
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=6f771e69645fd7bd71ac1782e768fedd0c3e3e1c
Submitter: Jenkins
Branch: master

commit 6f771e69645fd7bd71ac1782e768fedd0c3e3e1c
Author: Sebastian Kalinowski <email address hidden>
Date: Thu Sep 10 13:41:21 2015 +0200

Add validation for 'retries' param in puppet task

    Puppet tasks allow to specify 'retries' param to control
    how many retries will be performed in case of problems with
    puppet run. It should be validated to only allow integers.
    Additionally added example of usage.

    DocImpact
    Change-Id: I60d192582eacb6561650c1a309d480128b172f7a
    Closes-Bug: #1457794
    Depends-On: I819a019cf488fc1bd0d52b35d1693fcc088125cb

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

Vitaly Sedelnik (vsedelnik) wrote on 2015-10-08:

#6

Sebastian, please review the fix and backport to 7.0 if applicable. If not, please update the status accordingly (Won't Fix or Invalid).

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-15: Fix proposed to fuel-plugins (stable/7.0)

#7

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/235267

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-15: Fix proposed to fuel-astute (stable/7.0)

#8

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/235268

Revision history for this message

Sebastian Kalinowski (prmtl) wrote on 2015-10-15:

#9

Backports created.

Tomasz 'Zen' Napierala (tzn) on 2015-10-15

tags:

added: 70mu1-confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-18: Fix merged to fuel-astute (stable/7.0)

#10

Reviewed: https://review.openstack.org/235268
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=4703e7333c89116f4cc0b2ccee5f981683825c54
Submitter: Jenkins
Branch: stable/7.0

commit 4703e7333c89116f4cc0b2ccee5f981683825c54
Author: Sebastian Kalinowski <email address hidden>
Date: Wed Sep 9 13:36:31 2015 +0200

Allow to specify number of retries for puppet task

    Now it's possible to specify a number of retries for
    puppet task in granural deployment by specifying a new
    parameter "retries":

      parameters:
        ...
        retries: 10

By default, there are 2 retries.

    Change-Id: I819a019cf488fc1bd0d52b35d1693fcc088125cb
    Partial-Bug: #1457794
    (cherry picked from commit d89ea8c3c6d91e3c5151534f4145b50c45b25d13)

Dmitry Pyzhov (dpyzhov) on 2015-10-22

tags:

added: area-python

Revision history for this message

Anastasia Palkina (apalkina) wrote on 2015-10-29:

#11

Steps to reproduce from Sebastian:

1) Create a "puppet type" task that will fail
2) Add "retries: some_number" into parameters of this task
3) Add this task into deployment tasks
4) Execute this task
5) Look in puppet and/or asute logs to see if the task was retried given number of times

Nastya Urlapova (aurlapova) on 2015-11-02

tags:

removed: 70mu1-confirmed

Andrey Sledzinskiy (asledzinskiy) on 2015-11-03

tags:

added: on-verification

Revision history for this message

Andrey Sledzinskiy (asledzinskiy) wrote on 2015-11-03:

#12

Seems that retries aren't transferred to astute
I did next things:
1. Add 10 retries to https://bugs.launchpad.net/fuel/+bug/1457794 - http://paste.openstack.org/show/477877/
2. Modify /etc/puppet/modules/osnailyfacter/modular/netconfig/netconfig.pp by adding 'fail("foo is not bar")' anywhere
3. Sync deployment tasks - fuel release --sync-deployment-tasks --dir /etc/puppet/
4. Deploy any cluster
5. When it failed check puppet logs

Expected - 10 retries of netconfig.pp are present
Actual - only 3 retries are present:
grep 'MODULAR' /var/log/puppet.log
2015-11-03 16:53:10 +0000 Scope(Class[main]) (notice): MODULAR: hiera.pp
2015-11-03 16:53:14 +0000 Scope(Class[main]) (notice): MODULAR: fuel_pkgs.pp
2015-11-03 16:53:35 +0000 Scope(Class[main]) (notice): MODULAR: hiera.pp
2015-11-03 16:53:39 +0000 Scope(Class[main]) (notice): MODULAR: globals.pp
2015-11-03 16:53:43 +0000 Scope(Class[main]) (notice): MODULAR: logging.pp
2015-11-03 16:53:49 +0000 Scope(Class[main]) (notice): MODULAR: tools.pp
2015-11-03 16:54:04 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-03 16:54:08 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-03 16:54:12 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp

Then I run only netconfig task and again only 3 retries:
2015-11-03 17:03:35 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-03 17:03:39 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-03 17:03:42 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp

Revision history for this message

Andrey Sledzinskiy (asledzinskiy) wrote on 2015-11-03:

#13

fuel-snapshot-2015-11-03_17-16-10.tar.xz Edit (1.7 MiB, application/octet-stream)

Revision history for this message

Andrey Sledzinskiy (asledzinskiy) wrote on 2015-11-03:

#14

Fix should be verified on 8.0 iso also

Revision history for this message

Alexander Kurenyshev (akurenyshev) wrote on 2015-11-13:

#15

The same situation is for Fuel 8.0.
I did the same steps as Andrey and I got 3 retries after usual deployment:

root@node-1:~# grep 'MODULAR' /var/log/puppet.log
2015-11-13 11:21:33 +0000 Scope(Class[main]) (notice): MODULAR: hiera.pp
2015-11-13 11:21:40 +0000 Scope(Class[main]) (notice): MODULAR: fuel_pkgs.pp
2015-11-13 11:22:07 +0000 Scope(Class[main]) (notice): MODULAR: hiera.pp
2015-11-13 11:22:14 +0000 Scope(Class[main]) (notice): MODULAR: globals.pp
2015-11-13 11:22:20 +0000 Scope(Class[main]) (notice): MODULAR: logging.pp
2015-11-13 11:22:29 +0000 Scope(Class[main]) (notice): MODULAR: tools.pp
2015-11-13 11:22:52 +0000 Scope(Class[main]) (notice): MODULAR: umm.pp
2015-11-13 11:23:13 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 11:23:18 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 11:23:23 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp

and again 3 retires after granular netconfig task start:

2015-11-13 13:03:33 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 13:03:37 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 13:03:43 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp

Fuel used:

release_versions:
  2015.1.0-8.0:
    VERSION:
      api: '1.0'
      astute_sha: 959b06c5ef8143125efd1727d350c050a922eb12
      build_id: '116'
      build_number: '116'
      feature_groups:
      - mirantis
      fuel-agent_sha: 9da73b497be5f91cb79f91e74d73eb0525be1c71
      fuel-createmirror_sha: 84d5e9721848e84d65001718037370e52d2a0987
      fuel-library_sha: bc18428f04dd64dd81a3070b3733111e5c278e04
      fuel-nailgun-agent_sha: 00b4b11553c250f22c0079fb74c8b782dcb7b740
      fuel-nailgun_sha: 4ab6b1f994846fae5b14bcd7f892a621d21132bb
      fuel-ostf_sha: 2ddb42865ca466a58d23e04713e2d79cc54070c6
      fuel-upgrade_sha: 1e894e26d4e1423a9b0d66abd6a79505f4175ff6
      fuelmain_sha: cfed10fd84dc95a645e8760a49646e2303ab5d16
      fuelmenu_sha: ed146b5c5974eb19d723b3a2784abdd574df5a5e
      network-checker_sha: 722a2a46503cffa82d78243d516bf762cd9715fc
      openstack_version: 2015.1.0-8.0
      production: docker
      python-fuelclient_sha: a3b4d6b395c8d23c04a94925006e742caf9ff7cd
      release: '8.0'
      shotgun_sha: 25dd78a3118267e3616df0727ce746e7dead2d67
shotgun_sha: 25dd78a3118267e3616df0727ce746e7dead2d67

The same situation is for Fuel 8.0.
I did the same steps as Andrey and I got 3 retries after usual deployment:

root@node-1:~# grep 'MODULAR' /var/log/puppet.log
2015-11-13 11:21:33 +0000 Scope(Class[main]) (notice): MODULAR: hiera.pp
2015-11-13 11:21:40 +0000 Scope(Class[main]) (notice): MODULAR: fuel_pkgs.pp
2015-11-13 11:22:07 +0000 Scope(Class[main]) (notice): MODULAR: hiera.pp
2015-11-13 11:22:14 +0000 Scope(Class[main]) (notice): MODULAR: globals.pp
2015-11-13 11:22:20 +0000 Scope(Class[main]) (notice): MODULAR: logging.pp
2015-11-13 11:22:29 +0000 Scope(Class[main]) (notice): MODULAR: tools.pp
2015-11-13 11:22:52 +0000 Scope(Class[main]) (notice): MODULAR: umm.pp
2015-11-13 11:23:13 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 11:23:18 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 11:23:23 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp

and again 3 retires after granular netconfig task start:

2015-11-13 13:03:33 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 13:03:37 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp
2015-11-13 13:03:43 +0000 Scope(Class[main]) (notice): MODULAR: netconfig.pp

Fuel used:

release_versions:
  2015.1.0-8.0:
    VERSION:
      api: '1.0'
      astute_sha: 959b06c5ef8143125efd1727d350c050a922eb12
      build_id: '116'
      build_number: '116'
      feature_groups:
      - mirantis
      fuel-agent_sha: 9da73b497be5f91cb79f91e74d73eb0525be1c71
      fuel-createmirror_sha: 84d5e9721848e84d65001718037370e52d2a0987
      fuel-library_sha: bc18428f04dd64dd81a3070b3733111e5c278e04
      fuel-nailgun-agent_sha: 00b4b11553c250f22c0079fb74c8b782dcb7b740
      fuel-nailgun_sha: 4ab6b1f994846fae5b14bcd7f892a621d21132bb
      fuel-ostf_sha: 2ddb42865ca466a58d23e04713e2d79cc54070c6
      fuel-upgrade_sha: 1e894e26d4e1423a9b0d66abd6a79505f4175ff6
      fuelmain_sha: cfed10fd84dc95a645e8760a49646e2303ab5d16
      fuelmenu_sha: ed146b5c5974eb19d723b3a2784abdd574df5a5e
      network-checker_sha: 722a2a46503cffa82d78243d516bf762cd9715fc
      openstack_version: 2015.1.0-8.0
      production: docker
      python-fuelclient_sha: a3b4d6b395c8d23c04a94925006e742caf9ff7cd
      release: '8.0'
      shotgun_sha: 25dd78a3118267e3616df0727ce746e7dead2d67
shotgun_sha: 25dd78a3118267e3616df0727ce746e7dead2d67

Changed in fuel:
status:	Fix Committed → Confirmed
tags:	removed: on-verification

Alexey Shtokolov (ashtokolov) on 2015-11-13

Changed in fuel:
status:	Confirmed → Triaged

Sebastian Kalinowski (prmtl) on 2015-11-16

Changed in fuel:
assignee:	Sebastian Kalinowski (prmtl) → Fuel Python Team (fuel-python)

Fuel Devops McRobotson (fuel-devops-robot) on 2015-12-30

Changed in fuel:
milestone:	8.0 → 9.0
status:	Triaged → New

Revision history for this message

Aleksey Zvyagintsev (azvyagintsev) wrote on 2015-12-31:

#16

Looks like status was changes mistakenly. Revert back.

Changed in fuel:
status:	New → Triaged

Revision history for this message

Vitaly Sedelnik (vsedelnik) wrote on 2016-01-12:

#17

Retargeted for 7.0-mu-3, waiting for fix in 8.0 or 9.0

slava valyavskiy (slava-val-al) on 2016-01-12

Changed in fuel:
assignee:	Fuel Python Team (fuel-python) → slava valyavskiy (slava-val-al)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-12: Related fix proposed to fuel-web (master)

#18

Related fix proposed to branch: master
Review: https://review.openstack.org/266330

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Related fix merged to fuel-web (master)

#19

Reviewed: https://review.openstack.org/266330
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=713f8754f2300bdaad8e9f07767e50789b238c4d
Submitter: Jenkins
Branch: master

commit 713f8754f2300bdaad8e9f07767e50789b238c4d
Author: slava <email address hidden>
Date: Tue Jan 12 15:21:24 2016 +0300

Handle 'retries' parameter for puppet tasks on nailgun's side

    Currently, astute supports 'retries' parameter, but this
    parameter is not processed by nailgun, so, we always get
    default pupet retries value from astute component.

Change-Id: I68615b053ebc1c07bb8ca85084e48a9c93f5e495
Related-Bug: #1457794

slava valyavskiy (slava-val-al) on 2016-01-14

Changed in fuel:
status:	Triaged → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Related fix proposed to fuel-web (stable/8.0)

#20

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/267821

slava valyavskiy (slava-val-al) on 2016-01-14

no longer affects:

fuel/future

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Related fix proposed to fuel-web (stable/7.0)

#21

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/267843

Revision history for this message

Ihor Kalnytskyi (ikalnytskyi) wrote on 2016-01-15:

#22

Since it's not actually a bug, but enhancement, I don't think it's a good idea to accept it to stable branches.. especially after SCF.

Mark it as Won't fix then.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-18: Change abandoned on fuel-web (stable/8.0)

#23

Change abandoned by Valyavskiy Viacheslav (<email address hidden>) on branch: stable/8.0
Review: https://review.openstack.org/267821

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-18: Change abandoned on fuel-web (stable/7.0)

#24

Change abandoned by Valyavskiy Viacheslav (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/267843

Vitaly Sedelnik (vsedelnik) on 2016-02-12

tags:

added: wontfix-feature

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-02-26: Change abandoned on fuel-plugins (stable/7.0)

#25

Change abandoned by Igor Kalnitsky (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/235267
Reason: No updates for 4 months.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-14: Related fix proposed to fuel-docs (master)

#26

Related fix proposed to branch: master
Review: https://review.openstack.org/305742

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-14: Related fix merged to fuel-docs (master)

#27

Reviewed: https://review.openstack.org/305742
Committed: https://git.openstack.org/cgit/openstack/fuel-docs/commit/?id=d28f0c087d01f31189e6ffe221252284ff236f96
Submitter: Jenkins
Branch: master

commit d28f0c087d01f31189e6ffe221252284ff236f96
Author: Evgeny Konstantinov <email address hidden>
Date: Thu Apr 14 13:36:55 2016 +0300

Add puppet tasks retry count to Fuel Mitaka relnotes

Change-Id: I176dfd449deb6322bb773eb041d176142eb5dceb
Related-Bug: #1457794

Alisa Tselovalnikova (atselovalnikova) on 2016-06-03

tags:

added: on-verification

Revision history for this message

Alisa Tselovalnikova (atselovalnikova) wrote on 2016-06-03:

#28

Verify on fuel-9.0-mos-433-2016-06-03.
Number of retries can be specified for particular task.

Changed in fuel:
status:	Fix Committed → Fix Released
tags:	removed: on-verification

Fuel for OpenStack

[granular-deployment] No possibility to control retries count for puppet tasks

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Released	High	slava valyavskiy	Fuel for OpenStack 9.0
7.0.x	Won't Fix	High	slava valyavskiy	Fuel for OpenStack 7.0-updates
8.0.x	Won't Fix	High	slava valyavskiy	Fuel for OpenStack 8.0
Mitaka	Fix Released	High	slava valyavskiy	Fuel for OpenStack 9.0