Upgrading from 1.11 to 2.0.0 doesn't clean 1.11 skins nor uninstall entry (win)

[Sébastien BLAISOT]

Using windows installer for 1.12 beta on top of 1.11 installation let you with a C:\Programs\Mixxx\skin folder containing both of 1.11 + 1.12 skins

1.11 and 1.12 both appear in control panel -> programs -> uninstall

so basically, 1.12 installer doesn't detect previous installation and is not an upgrade process, but an "install on top" process

I think this should be resolved before 1.12 release, either by having an upgrade process in the installer, or by blocking installation if previous version is still installed (install dir not empty for example)

[Sébastien BLAISOT (sblaisot)]

following dicsussion on mailing list, the retained approach is to install Mixxx in a "Mixxx $VERSION" directory.

[Sébastien BLAISOT (sblaisot)]

https://github.com/mixxxdj/mixxx/pull/621

[Owen Williams (ywwg)]

I disagree that it's a bug that the user has access to both 1.11 and 1.12 skins. Some people may want to hang on to their old or custom skins. We have code that, when 1.12 is first launched, looks to see what skin the user had in 1.11 and finds the equivalent skin in 1.12. This way the user is shown a brand new skin but can easily go back to the old one. If that functionality is broken, that would be a separate bug. (see SkinLoader::pickResizableSkin).

While it is annoying that the Uninstall menu will have multiple entries, I don't think we should change the install location for this release.

[Sébastien BLAISOT (sblaisot)]

Ok, so I close the PR and we will work on a new installer for the next version.

[Sébastien BLAISOT (sblaisot)]

Owen, I strongly disagree with your last comment the same way I previously disagree to the same argument about controller preset from rryan.

Program installation directory is not supposed to be modified by the user (at least we should not encourage users to do so).
The user should have a way to put its modified skin in his homedir the same way he can put it's own controller presets in his settings dir.

everything that comes installed by the software can be deleted by the uninstalling or upgrading of the software without notice, with an exception for configuration files that have to be marked as such and with a possibility for the user to choose between "keep my configuration" or "remove everything" upon uninstallation.

so this is, to me, a problem of our skin engine (as far as I know it doesn't currently allow custom skins in settings dir).
The decision seems reasonable with this problem however.

[Owen Williams (ywwg)]

What about continuing to include the old skins in the installer?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8042