jobs using recovery_info use it incorrectly

Bug #1457505 reported by Daniel Manrique
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Critical
Daniel Manrique

Bug Description

Jobs using the new recovery_info script use it incorrectly (maybe the script was changed but the jobs weren't, from an old version?).

For example, info/detect_recovery does recovery_info --check-recovery-partition, when apparently it should omit the parameters (per the script's help and my tests, just calling it with no parameters returns 0 if there's a recovery partition and 1 if there isn't).

The affected jobs are:

id: info/detect_recovery
id: info/detect_dell_recovery
id: recovery_info_attachment
id: dell_bto_xml_attachment

Here's a run of all the affected jobs:

$ for i in 2013.com.canonical.certification::{dell_bto_xml_attachment,recovery_info_attachment,info/detect_recovery,info/detect_dell_recovery}; do plainbox dev script $i; done
(job 2013.com.canonical.certification::dell_bto_xml_attachment, <stderr:00001>) usage: recovery_info [-h] {version,file,checktype} ...
(job 2013.com.canonical.certification::dell_bto_xml_attachment, <stderr:00002>) recovery_info: error: invalid choice: 'bto.xml' (choose from 'version', 'file', 'checktype')
job 2013.com.canonical.certification::dell_bto_xml_attachment returned 2
command: recovery_info --readfile bto.xml
(job 2013.com.canonical.certification::recovery_info_attachment, <stderr:00001>) usage: recovery_info [-h] {version,file,checktype} ...
(job 2013.com.canonical.certification::recovery_info_attachment, <stderr:00002>) recovery_info: error: unrecognized arguments: --show-version
job 2013.com.canonical.certification::recovery_info_attachment returned 2
command: recovery_info --show-version
(job 2013.com.canonical.certification::info/detect_recovery, <stderr:00001>) usage: recovery_info [-h] {version,file,checktype} ...
(job 2013.com.canonical.certification::info/detect_recovery, <stderr:00002>) recovery_info: error: unrecognized arguments: --check-recovery-partition
job 2013.com.canonical.certification::info/detect_recovery returned 2
command: recovery_info --check-recovery-partition
(job 2013.com.canonical.certification::info/detect_dell_recovery, <stderr:00001>) usage: recovery_info [-h] {version,file,checktype} ...
(job 2013.com.canonical.certification::info/detect_dell_recovery, <stderr:00002>) recovery_info: error: invalid choice: 'DELL' (choose from 'version', 'file', 'checktype')
job 2013.com.canonical.certification::info/detect_dell_recovery returned 2
command: recovery_info --check-recovery-type DELL

Related branches

Daniel Manrique (roadmr)
Changed in plainbox-provider-checkbox:
assignee: nobody → Daniel Manrique (roadmr)
status: Triaged → In Progress
Zygmunt Krynicki (zyga)
Changed in plainbox-provider-checkbox:
status: In Progress → Fix Committed
Changed in plainbox-provider-checkbox:
milestone: none → 0.21
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.