DM: apply groups is not pushed to the router

[Ganesha HV]

[2.20-26~juno-ubuntu-14.04]

Topo
====
nodeb12

1]. Added 'yuvaraj' as a BGP router and Physical router from UI.
2]. I see that this config is pushed onto the MX :

regress@yuvaraj# show | display set
set version 15.1B1-PS.4
set groups __contrail__ routing-options route-distinguisher-id 10.204.217.190
set groups __contrail__ routing-options autonomous-system 64512
set groups __contrail__ protocols bgp group __contrail__ type internal
set groups __contrail__ protocols bgp group __contrail__ multihop
set groups __contrail__ protocols bgp group __contrail__ local-address 10.204.217.190
set groups __contrail__ protocols bgp group __contrail__ hold-time 90
set groups __contrail__ protocols bgp group __contrail__ keep all
set groups __contrail__ protocols bgp group __contrail__ family inet-vpn unicast
set groups __contrail__ protocols bgp group __contrail__ family inet6-vpn unicast
set groups __contrail__ protocols bgp group __contrail__ family evpn signaling
set groups __contrail__ protocols bgp group __contrail__ family route-target
set groups __contrail__ protocols bgp group __contrail__ neighbor 10.204.216.5
set groups __contrail__ protocols bgp group __contrail_external__ type external
set groups __contrail__ protocols bgp group __contrail_external__ multihop
set groups __contrail__ protocols bgp group __contrail_external__ local-address 10.204.217.190
set groups __contrail__ protocols bgp group __contrail_external__ hold-time 90
set groups __contrail__ protocols bgp group __contrail_external__ keep all
set groups __contrail__ protocols bgp group __contrail_external__ family inet-vpn unicast
set groups __contrail__ protocols bgp group __contrail_external__ family inet6-vpn unicast
set groups __contrail__ protocols bgp group __contrail_external__ family evpn signaling
set groups __contrail__ protocols bgp group __contrail_external__ family route-target
set system root-authentication encrypted-password "$1$d7Su9PJN$pr8/H7yxt282oZYJWNAxL."
set system login user regress uid 19005
set system login user regress class super-user
set system login user regress authentication encrypted-password "$1$88V/Z5ce$dZZo/4iZaFsrGlQuSMgwl."
set system services ftp

3]. I don't see apply-groups config pushed.

4]. also, the following logs are seen on the node :

root@nodeb12:~# 05/21/2015 04:36:31 PM [nodeb12:DeviceManager:Config:0]: Router 10.204.217.190: invalid ip address or hostname:

[Suresh Balineni (sbalineni)]

physical_router data plane_ip is set to empty string. Currently, DM has validation for null' check for this parameter. Should validate the ip-address.

apply-groups won't added to candidate config on failed scenario. When DM tries to send delete config, it adds 'apply_group' also, since '__contrail__' apply-group is not present , Mx throws warning. Its no-op operation. Should not be a problem.

      <routing-options>
        <dynamic-tunnels>
          <dynamic-tunnel>
            <name>__contrail__</name>
            <source-address></source-address>
            <gre/>
            <destination-networks>
              <name>10.204.217.190/32</name>
            </destination-networks>
            <destination-networks>
              <name>10.204.216.5/32</name>
            </destination-networks>
          </dynamic-tunnel>
        </dynamic-tunnels>
      </routing-options>
    </groups>
    <apply-groups operation="replace">__contrail__</apply-groups>
  </configuration>
</config>

05/22/2015 06:20:56 AM [nodeb12:DeviceManager:Config:0]: Router 10.204.217.190: invalid ip address or hostname:

#Disable auto-config
05/22/2015 06:25:49 AM [nodeb12:DeviceManager:Config:0]: Notification Message: {u'oper': u'UPDATE',
 u'type': u'physical-router',
 u'uuid': u'bd6546d2-dd8a-430a-b2a6-fd5639d9f6de'}
05/22/2015 06:25:50 AM [nodeb12:DeviceManager:Config:0]:
send netconf message: <config xmlns:xc="urn:ietf:params:xml:ns:netconf:base:1.0">
  <configuration>
    <groups operation="delete">
      <name>__contrail__</name>
    </groups>
    <apply-groups operation="delete">__contrail__</apply-groups>
  </configuration>
</config>

05/22/2015 06:25:51 AM [nodeb12:DeviceManager:Config:0]: Router 10.204.217.190: statement not found: apply-groups __contrail__

[Ganesha HV (ganeshahv)]

1]. Adding Physical interface/logical interface after creating a virtual-network has no effect on the config pushed to MX.

This is in R2.20-39-juno..

marking it as a blocker

The setup is intact.

nodeb12 - yuvaraj(mx)

[Suresh Balineni (sbalineni)]

I debugged Ganesha's setup.
Ganesha: Issue already discussed in #1, You need to configure "data plane_ip" or don't set any value for this (currently it is set as empty string),
dataplane_ip validation was missing in DM. The fix is in review state (https://review.opencontrail.org/#/c/10686/)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11338
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11339
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11339
Committed: http://github.org/Juniper/contrail-controller/commit/ad66ff5a048e7ebe639ca2d6d3a2594eee7fb892
Submitter: Zuul
Branch: master

commit ad66ff5a048e7ebe639ca2d6d3a2594eee7fb892
Author: sbalineni <email address hidden>
Date: Fri Jun 5 18:37:55 2015 -0700

validate physical router dataplane ip

DM uses physical router dataplane ip as tunnel source ip for pogramming
dynamic tunnels on mx. Currently there is no validation for ip in DM, this fix
validates the ip address and if not valid then skip dynamic tunnels.

Change-Id: I50b31d0d487362f33ac62da803877a8396d3c317
Closes-Bug: #1457442

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11338
Committed: http://github.org/Juniper/contrail-controller/commit/3e9e4a3dfe7ceaf2e111666971a1554afe512362
Submitter: Zuul
Branch: R2.20

commit 3e9e4a3dfe7ceaf2e111666971a1554afe512362
Author: sbalineni <email address hidden>
Date: Fri Jun 5 18:30:45 2015 -0700

validate physical router dataplane ip

DM uses physical router dataplane ip as tunnel source ip for pogramming
dynamic tunnels on mx. Currently there is no validation for ip in DM, this fix
validates the ip address and if not valid then skip dynamic tunnels.

Change-Id: I3693cfc4ce7a070431c029eb1cf1cf47147ef67b
Closes-Bug: #1457442