Potential code diverge after Fuel-library switched to the packaging system for binaries/init/OCF scripts

[Bogdan Dobrelya]

After the patch https://review.openstack.org/#/c/172542
We may have got the code diverged in the deployment/ vs files/ vs debian/ locations. This must be double-checked and deployment/ changes, if any, syncronized to the files/ or debian/ dst and originals must be removed from the fuel-library repo as we now maintain only files/ location for binaries, OCF/init scripts.

Example of the potential code diverge:
files/rabbit-fence/rabbit-fence.init - ok. New destination to maintain.
deployment/puppet/cluster/files/rabbit-fence.init - obsoleted, should be synced and removed.
debian/fuel-rabbit-fence.upstart - ok. New destination to maintain.
deployment/puppet/cluster/files/rabbit-fence.upstart - obsleted, should be synced and removed.

After the manual check for the code diverge, we should update the CI gate for packaging of fuel-library in order to make this diverge impossible in the late.

[Vladimir Kuklin (vkuklin)]

I specially rechecked all the files after partiuclar commit was merged - there is no divergence

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/184966

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/184966
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=2e7660b5f73634077cc71ba53672dcfda8c46d61
Submitter: Jenkins
Branch: master

commit 2e7660b5f73634077cc71ba53672dcfda8c46d61
Author: Bogdan Dobrelya <email address hidden>
Date: Fri May 22 09:47:43 2015 +0200

    Sync rabbit OCF code diverge to packages

    W/o this patch, the code in OCF script from
    deployment/ dir will never get to the fuel-library
    packages, which are building from files/ and /debian
    dirs only.

    The solution is:
    1) sync the code diverged to the files/ and debian/
    2) either to remove the source OCF file or to
    update the way files being linked.

    This patch fixes only the step 1 as there is not yet
    decided how to deal with the step 2.

    Related-bug: #1457441
    Related-bug: #184966

    Change-Id: Ied86640e8e853de99bcd26f1ae726fc8272b6db7
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/185064

[Bogdan Dobrelya (bogdando)]

@Vladimir Kuklin, there was at least one, please see the patch https://review.openstack.org/184966

[Bogdan Dobrelya (bogdando)]

And please note, we should prevent an OCF/binaries being merged to the deployment/ destination in the future, so this bug is valid - as we have to either remove all duplicated files from the repo, or make a kind of automatic syncronization from /deployment to /fiels and /debian.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185064
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c4e2a340c5a17a8a0c5e1812efd323e96a6fb865
Submitter: Jenkins
Branch: master

commit c4e2a340c5a17a8a0c5e1812efd323e96a6fb865
Author: Dmitry Ilyin <email address hidden>
Date: Fri May 22 19:38:31 2015 +0300

    Sync unsynced file form puppet library

    Related-Bug: 1457441
    Change-Id: I082a566c30ab9dd80647da30ea6ac91b3c532387

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/205244

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/205244
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=7117b6cfd43de4acf9f3febac3a8b09310747942
Submitter: Jenkins
Branch: master

commit 7117b6cfd43de4acf9f3febac3a8b09310747942
Author: Alex Schultz <email address hidden>
Date: Thu Jul 23 13:31:50 2015 -0500

    Old ocf file cleanup

    This change removes missed ocf scripts from deployment/ and moves
    any still referenced files to files/fuel-ha-utils. Also cleans up
    commented out ocf files from the puppet code.

    Change-Id: Ie6bd1bae40fab175aff14274026bf506f28eb0e4
    Related-Bug: 1457441

[Vladimir Kuklin (vkuklin)]

This should be covered by tests.

[Andrey Maximov (maximov)]

This is not a functional bug but rather technical debt which we should address in the future. Lowering priority to medium and moving out of 7.0 scope.

[Matthew Mosesohn (raytrac3r)]

This seems done. It's hard to write tests coverage for shifting code location

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/185063