Program Icon on Taskbar should migrate with window when moved to another desktop (3d desktop)

[nulled]

I am running Ubuntu Feisty Fawn with Beryl and Avant Navigator.

This may or may not be a bug.

If I Spawn a program naturally I will see the Programs ICON on Avant's Task bar as it should.

But, if I move that same spawned program to another desktop ( say from Desktop #1 to Desktop #2)
Avant (in my view) should move the taskbar Icon with it to desktop #2.

I know that the program was spawned from Desktop #1 however, it would be cool if Avant would also
readjust or move program Icons so they follow their Window if that window is moved to another desktop/viewport.

:)

Keep in mind I have "Show windows from all Viewports UNCHECKED"

[Andrew Starr-Bochicchio (andrewsomething)]

Running Compiz Fusion on Gutsy, I can reproduce this if the window is moved through the window's left click context menu. If I physically drag it to another workspace, the icon updates as expected.

[haytjes (h4writer)]

Also affects awn-rewrite. Bug in awn-rewrite is even worse. This should be fixed before release of awn-rewrite.

[haytjes (h4writer)]

This patch should solve it.
Problem was that Compiz uses viewports instead of workspaces.
Also Wnck doesn't deal well with viewports. Atleast there is no easy way to know if a window is moved from one viewport to another. This patch listens to the moves of the window and determinates if the window is moved off the viewport and then asks awn-task-manager to check every task if it should be visible.

I'm still doubting to add a key (like in shiny-switcher) to determinate first if the workspace is working with viewports and then only run the code when there are viewports?

[moonbeam (rcryderman)]

haytjes,

The relevant code for detecting viewports in shinyswitcher is

=================
  shinyswitcher->got_viewport = wnck_workspace_is_virtual(wnck_screen_get_active_workspace(shinyswitcher->wnck_screen));

  if (wnck_screen_get_window_manager_name(shinyswitcher->wnck_screen))
    if (strcmp(wnck_screen_get_window_manager_name(shinyswitcher->wnck_screen), "compiz") == 0)
    {
      printf("ShinySwitcher Message: compiz detected\n");
      shinyswitcher->got_viewport = TRUE;
    }
=================

We don't have to use a config key at all... and the signals can be hooked up conditionally based on the result.

[Michal Hruby (mhr3)]

Attached is edited h4writer's patch with moonbeam's suggestion.

@moonbeam: Please review.

[moonbeam (rcryderman)]

I'll review fully tomorrow.... but the use of wnck_screen_force_update() probably needs to be removed.

I will definitely make time tomorrow (taking it somewhat easy).

[Michal Hruby (mhr3)]

Note that without the use of wnck_screen_force_update(), I was unable to get valid workspace wnck_screen_get_active_workspace() and also wnck_window_get_workspace() returned always NULL.

[moonbeam (rcryderman)]

if wnck_screen_force_update() is only called on startup of awn then that is ok.

[Michal Hruby (mhr3)]

Fix pushed to trunk r533.