Adding paging via next_batch in ifmap introspect commands

Bug #1457216 reported by Tapan Karwa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
Medium
Tapan Karwa
Trunk
Fix Committed
Medium
Tapan Karwa

Bug Description

Currently, a few IFMap introspects commands buffer the entire table and then send in batches. This will not work in scaling scenarios where the number of nodes/links is huge. Change both the introspects to buffer/send 50 entries at a time and add code to iterate by providing a next_batch link on the client page.

Tapan Karwa (tkarwa)
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/10186
Submitter: Tapan Karwa (<email address hidden>)

Nischal Sheth (nsheth)
tags: added: contrail-control
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/10186
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12167
Submitter: Shashikiran H (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12168
Submitter: Shashikiran H (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12259
Submitter: Shashikiran H (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12168
Submitter: Shashikiran H (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12168
Committed: http://github.org/Juniper/contrail-test/commit/251ac118bd2412f142c1a37cabc623b94f76cd4e
Submitter: Zuul
Branch: R2.20

commit 251ac118bd2412f142c1a37cabc623b94f76cd4e
Author: skiranh <email address hidden>
Date: Fri Jul 3 16:00:20 2015 +0530

Modifying scripts to accomodate pagination changes

Recent pagination changes to ifmap requires changes to our script. Modifying the script to get only the exact match.
Correcting re requirement

Change-Id: I7a0ea83c040f6f304ad94747addc623346f94780
Closes-Bug: 1457216

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12325
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12363
Submitter: Shashikiran H (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12325
Committed: http://github.org/Juniper/contrail-controller/commit/86ba1027bdfe97a6b76538ddfdef3a2e516bb77d
Submitter: Zuul
Branch: R2.20

commit 86ba1027bdfe97a6b76538ddfdef3a2e516bb77d
Author: Tapan Karwa <email address hidden>
Date: Mon May 11 10:04:30 2015 -0700

Scaling changes for introspect.

1. Currently, the IFMapTableShowReq and IFMapTableShowReq introspects buffer
the entire table and then send in batches. This will not work in scaling
scenarios where the number of nodes/links is huge. Change both the introspects
to buffer/send 50 entries at a time and add code to iterate by providing a
next_batch link on the client page.
2. Add the table size for the link-table as part of the introspect output. The
link-table size output cannot be put in IFMapNodeTableListShowReq since the
table names in that show are clickable.
3. Add new APIs in the db-partition code needed by the above changes.

Closes-Bug: 1457216

Change-Id: Ia5694269917913da36c2efc341293ba4f6f9350d

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12363
Committed: http://github.org/Juniper/contrail-test/commit/8900959c699cc20e5e38ffb3515ab02d2113abdd
Submitter: Zuul
Branch: master

commit 8900959c699cc20e5e38ffb3515ab02d2113abdd
Author: skiranh <email address hidden>
Date: Mon Jul 13 15:37:31 2015 +0530

Modifying scripts to accomodate pagination changes

Recent pagination changes to ifmap requires changes to our script. Modifying the script to get only the exact match.
Correcting re requirement

Change-Id: I93b57a6418cb75c6dec7d1e6aed30a64724d2e3f
Closes-Bug: 1457216

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/10186
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/10186
Committed: http://github.org/Juniper/contrail-controller/commit/2e4276c4a7869d2b19e46ddf76adde6ee3ac34a7
Submitter: Zuul
Branch: master

commit 2e4276c4a7869d2b19e46ddf76adde6ee3ac34a7
Author: Tapan Karwa <email address hidden>
Date: Mon May 11 10:04:30 2015 -0700

Scaling changes for introspect.

1. Currently, the IFMapTableShowReq and IFMapTableShowReq introspects buffer
the entire table and then send in batches. This will not work in scaling
scenarios where the number of nodes/links is huge. Change both the introspects
to buffer/send 50 entries at a time and add code to iterate by providing a
next_batch link on the client page.
2. Add the table size for the link-table as part of the introspect output. The
link-table size output cannot be put in IFMapNodeTableListShowReq since the
table names in that show are clickable.
3. Add new APIs in the db-partition code needed by the above changes.

Closes-Bug: 1457216

Change-Id: Ia5694269917913da36c2efc341293ba4f6f9350d

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.