Bootstrap variables overrides should only be default values

Bug #1457188 reported by Diana Whitten
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Diana Whitten

Bug Description

static/dashboard/scss/_variables.scss:

Bootstrap variables overrides should only be default values to allow for skin variables to override properly

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/184595

Changed in horizon:
assignee: nobody → Diana Whitten (hurgleburgler)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/184595
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=71d495f4aded416f6c4c7fb7ada1ef1426a5902f
Submitter: Jenkins
Branch: master

commit 71d495f4aded416f6c4c7fb7ada1ef1426a5902f
Author: Diana Whitten <email address hidden>
Date: Wed May 20 12:17:20 2015 -0700

    Bootstrap variable overrides should only be default values

    In openstack_dashboard/static/dashboard/scss/_variables.scss, the 4
    bootstrap variables 'overrides' should only be defaults to allow
    for skinning.

    Change-Id: I88384f4fb75f4e8c3cf4d33ae89c73e8f04c7b1d
    Closes-Bug: #1457188

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Medium
milestone: none → liberty-1
Changed in horizon:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187797

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/187797
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e1d1cc92ee5ef493b1bf1ed2d581cae04f17df02
Submitter: Jenkins
Branch: master

commit e1d1cc92ee5ef493b1bf1ed2d581cae04f17df02
Author: Diana Whitten <email address hidden>
Date: Tue Jun 2 15:29:01 2015 -0700

    Bootstrap variables should derive from a known theme.

    In openstack_dashboard/static/dashboard/scss/_variables.scss, the 4
    bootstrap variables 'overrides' should actually come from the theme.
    Instead of pulling in the very basic Bootstrap skin for overrides,
    the default theme should bring in the default Bootstrap and change
    the appropriate variables for horizon.

    Change-Id: Ib017ca378b5cbc727f7e0f5055d98c41f159435e
    Closes-Bug: #1457188

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.