39 to 40 upgrade fails when DB is caring about boolean type

[Romain Chantereau]

When applying the 39 to 40 upgrade, the new volume_attachment table is populated with migrated values.

In this process, the records are tagged as not deleted by default.

As the deleted column type is “boolean”, the upgrade code specifies “0” as value. But 0 is a logically false integer value but not a boolean False value. Then sqlAlchemy just pass the integer value and if the DB cares about boolean type (like Postgresql) the insert fails.

Just by letting sqlalchemy do the conversion to the DB relative type the upgrade works in every case, and if not, it will be a sqlalchemy bug ;-)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184478

[Anton Arefiev (aarefiev)]

Fix Committed means patch with fix merged

[Romain Chantereau (romain-m)]

Thanks Anton, sorry for the bad status.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/184478
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dc1dcbb9c847b531593d7d6b130ac2b2d04e5302
Submitter: Jenkins
Branch: master

commit dc1dcbb9c847b531593d7d6b130ac2b2d04e5302
Author: Romain Chantereau <email address hidden>
Date: Wed May 20 15:06:36 2015 +0200

    Leave sqlalchemy convert to boolean to the DB SQL type to use.

    Closes-Bug: #1457033

    Change-Id: I969a4d60aa156ccfff09a58c3a448b5a9619e71f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/251790

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bertrand Lallau (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/251790