Instance UUID and Instance name is misused in virt/vmwareapi/vmops.py

Bug #1456872 reported by Zhenyu Zheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Zhenyu Zheng

Bug Description

In \nova\virt\vmwareapi\vmops.py, at the end of method get_vnc_console(self, instance), a log has been printed. In this log, the data content of instance.name is assigned to key "UUID", which is not correct. Since instance name can be same to more than one instances, we should use instance.uuid.

Changed in nova:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/184662

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/184662
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0318938282b67a3d6de5a9d0017ec9833bb9f85c
Submitter: Jenkins
Branch: master

commit 0318938282b67a3d6de5a9d0017ec9833bb9f85c
Author: Kevin_Zheng <email address hidden>
Date: Thu May 21 08:45:55 2015 +0800

    VMware: Log should use uuid instead of name

    The data content of instance.name is assigned
    to key "UUID", which is not correct. Since instance name
    can be same to more than one instances, we should use
    instance.uuid.

    Change-Id: I96a02fefd21eeb7f5d7be7fa11f690ae3e7163bc
    Closes-Bug:1456872

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.