centos kernel: apply do_tcp_sendpages fix from the upstream kernel

Bug #1456605 reported by Pavel Boldin
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Pavel Boldin

Bug Description

During the Root Cause Analysis of the bug [1] it was discovered that the CentOS Kernel lacks the necessary patch [2] that fixes the NULL-dereferencing bug.

Fix this by applying a modified patch to our kernel.

[1] https://bugs.launchpad.net/fuel/+bug/1449977
[2] http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=64022d0b4e93ea432e95db55a72b8a1c5775f3c0

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/centos6/kernel (6.1)

Fix proposed to branch: 6.1
Change author: Pavel Boldin <email address hidden>
Review: https://review.fuel-infra.org/6798

Revision history for this message
Pavel Boldin (pboldin) wrote :
Changed in fuel:
assignee: nobody → Pavel Boldin (pboldin)
importance: Undecided → High
status: New → In Progress
milestone: none → 6.1
Revision history for this message
Pavel Boldin (pboldin) wrote :

Preliminary results show that this fixes the bug. More to follow from Mellanox team.

Revision history for this message
Aviram Bar-Haim (aviramb) wrote :

Reproduced the problem on ISO 429, CentOS with Classic provisioning over Ethernet, with 1 controller.

After installing the following packages I've got from Pavel:
kernel-2.6.32-504.1.3.el6.mos61.x86_64.rpm
kernel-headers-2.6.32-504.1.3.el6.mos61.x86_64.rpm
kernel-devel-2.6.32-504.1.3.el6.mos61.x86_64.rpm

And recompiling OFED on the new kernel + restart networking, I was able to create snapshot and boot a new VM from it successfully.

We'll try to run stress tests over this fix and we'll update ASAP. Thanks Pavel!

Pavel Boldin (pboldin)
Changed in fuel:
assignee: Pavel Boldin (pboldin) → Amichay Polishuk (amichayp)
Revision history for this message
Amichay Polishuk (amichayp) wrote :

Verified : Tested with the same environment, no exception.

More tests (Stress / Rally) will be execute with a closed ISO.

Revision history for this message
Andrey Maximov (maximov) wrote :

can you test this change with custom ISO to ensure that kernel version update will not break BVT?

Revision history for this message
Pavel Boldin (pboldin) wrote :
Revision history for this message
Aviram Bar-Haim (aviramb) wrote :

+ We're checking classic installation after adding the new kernel RPMs to Fuel CentOS localrepo, over ISO 429.

Revision history for this message
Pavel Boldin (pboldin) wrote :

Both BVTs are green.

Pavel Boldin (pboldin)
Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/centos6/kernel (6.1)

Reviewed: https://review.fuel-infra.org/6798
Submitter: Michael Semenov <email address hidden>
Branch: 6.1

Commit: a1f1c85928e4394822315c753c759fe61a76def8
Author: Pavel Boldin <email address hidden>
Date: Tue May 19 13:07:07 2015

fix oops in do_tcp_sendpages

Apply the upstream patch http://git.kernel.org/cgit/linux/kernel/git/stable/\
linux-stable.git/commit/?id=64022d0b4e93ea432e95db55a72b8a1c5775f3c0 to fix
the oops in `do_tcp_sendpages'.

Change-Id: Id0f6d1ccd9e0abd856da385f2ad461a022431a7e
Closes-Bug: #1456605
Related-Bug: #1449977

Pavel Boldin (pboldin)
Changed in fuel:
status: Fix Committed → Fix Released
Pavel Boldin (pboldin)
Changed in fuel:
status: Fix Released → Fix Committed
assignee: Amichay Polishuk (amichayp) → Pavel Boldin (pboldin)
Revision history for this message
Amichay Polishuk (amichayp) wrote :

I will check the fix on version - ISO 460, will update my finding here.

Revision history for this message
Pavel Boldin (pboldin) wrote :

The fix was checked and released in 6.1.

Upstream kernel, according to source code research, still do suffer from this regression.

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.