Bad translation strings in code

Bug #1456599 reported by Michael Zanetti
34
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Telegram app
Fix Released
High
Unassigned

Bug Description

There are some bad translations and I wanted to fix them, but turns out, it's actually a problem in the code:

Example: %1 added %2

This string is used for someone else adding someone to a group, but also if the user of the app adds someone to a group. In German this is translated to:

%1 hat %2 hinzugefügt

This is fine in the case of

John added Frank -> John hat Frank hinzugefügt

However, in the case of the user himself performing this action it ends up being

You added John -> Sie hat John hinzugefügt

This however translates back to english as "She added John" and instead should be "%1 haben %2 hinzugefügt"

Basically the string needs to be split up into other people's actions and this user's actions.

Same goes for "%1 created %2". Not sure if there are more of them, but those happen frequently in the ui.

Tags: i18n

Related branches

Revision history for this message
Michał Karnicki (karni) wrote :

Thanks. Even better, self actions should not be "You removed karni" but "You left the chat", etc.

Changed in libqtelegram:
status: New → Triaged
description: updated
Revision history for this message
Olivier Tilloy (osomon) wrote :

FWIW, the same happens in French.

Michał Karnicki (karni)
Changed in telegram-app:
importance: Undecided → High
Michał Karnicki (karni)
tags: added: i18n
Revision history for this message
Jin (jindallo) wrote :

I confirmed this,
will find the proper owner to do the translation.

Changed in telegram-app:
status: Triaged → Confirmed
Jin (jindallo)
Changed in telegram-app:
assignee: nobody → Jin (jin.cth)
Jin (jindallo)
Changed in telegram-app:
status: Confirmed → In Progress
Revision history for this message
Jin (jindallo) wrote :
Revision history for this message
Jin (jindallo) wrote :

Bug fixed,
and verified pass on developer side.

The change list is submitted as rev. 173,
below is the detail information.
    http://bazaar.launchpad.net/~libqtelegram-team/telegram-app/telegram/revision/173

Device Information:
    current build number: 414
    device name: mako
    channel: ubuntu-touch/rc-proposed/ubuntu
    last update: 1970-01-01 08:08:15
    version version: 414
    version ubuntu: 20160408.3
    version device: 20160401.1
    version custom: 20160408.3

Changed in telegram-app:
milestone: none → m29
status: In Progress → Fix Committed
Jin (jindallo)
Changed in telegram-app:
status: Fix Committed → Fix Released
assignee: Jin (jin.cth) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.