[Mainline 2591] SNAT launch fails without default-network-ipam in project where logical router is created

[Prakash Bailkeri]

With the commit https://github.com/Juniper/contrail-controller/commit/092aa656ab682de3756d2bc77b1bdd87427817f1, it is expected that every project, where router is created, contains the network-ipam with name "default-network-ipam".

Before this commit, for the creation of snat svc network, "default-domain:default-project:default-network-ipam" was used.

Since the sanity scripts doesn't create the "default-network-ipam" in every project, router sanity is failing as snat service instance is not launched.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/svc_monitor/svc_monitor.py", line 685, in _create_service_instance
    self.netns_manager.create_service(st, si)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/instance_manager.py", line 536, in create_service
    if not self.validate_network_config(st, si):
  File "/usr/lib/python2.7/dist-packages/svc_monitor/instance_manager.py", line 234, in validate_network_config
    vn_id = self._create_snat_vn(si, vn_fq_str, index)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/instance_manager.py", line 580, in _create_snat_vn
    si.fq_name[:-1], user_visible=False)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/instance_manager.py", line 167, in create_service_vn
    ipam_obj = self._vnc_lib.network_ipam_read(fq_name=ipam_fq_name)
  File "/usr/lib/python2.7/dist-packages/vnc_api/gen/vnc_api_client_gen.py", line 5141, in network_ipam_read
    (args_ok, result) = self._read_args_to_id('network-ipam', fq_name, fq_name_str, id, ifmap_id)
  File "/usr/lib/python2.7/dist-packages/vnc_api/vnc_api.py", line 352, in _read_args_to_id
    return (True, self.fq_name_to_id(obj_type, fq_name))
  File "/usr/lib/python2.7/dist-packages/vnc_api/vnc_api.py", line 461, in fq_name_to_id
    content = self._request_server(rest.OP_POST, uri, data=json_body)
  File "/usr/lib/python2.7/dist-packages/vnc_api/vnc_api.py", line 368, in _request_server
    retry_count=retry_count)
  File "/usr/lib/python2.7/dist-packages/vnc_api/vnc_api.py", line 409, in _request
    % (op, url, data, content))
NoIdError: Unknown id: Error: oper 1 url /fqname-to-id body {"fq_name": ["default-domain", "admin", "default-network-ipam"], "type": "network-ipam"} response Name [u'default-domain', u'admin', u'default-network-ipam'] not found

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10571
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10571
Committed: http://github.org/Juniper/contrail-controller/commit/4190622915e943319e7705e5021eb7a11c97e5b0
Submitter: Zuul
Branch: master

commit 4190622915e943319e7705e5021eb7a11c97e5b0
Author: Sachin Bansal <email address hidden>
Date: Tue May 19 15:04:20 2015 -0700

If default-network-ipam is not found in the project, use global default ipam

Change-Id: I4566e663eb48bb670377fc914b9da59a60f37208
Closes-Bug: 1456541