Creation of multinode without HA cluster accessible via cli without enabling experimental mode in the astute.yaml

[Egor Kotko]

Creation of multinode without HA cluster accessible via cli without enabling experimental mode in the astute.yaml
Is this correct behaviour?

help contains:
 --mode {multinode,ha}, -m {multinode,ha}, --deployment-mode {multinode,ha}
                        Set deployment mode for specific environment.

[root@nailgun ~]# fuel env create --name=stambul --mode=multinode --rel=1 --name=test
Environment 'test' with id=1, mode=multinode and network-mode=nova_network was created!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184232

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184425

[OpenStack Infra (hudson-openstack)]

Change abandoned by Maciej Kwiek (<email address hidden>) on branch: master
Review: https://review.openstack.org/184232
Reason: This should be handled in nailgun. Will add a warning to client.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184453

[Tomasz 'Zen' Napierala (tzn)]

Guys, any explanation why this is high?

[Mike Scherbakov (mihgen)]

This is not High in my opinion. More over, I'd just allow experimental in CLI by default - and just add warnings for certain operations which are experimental.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/184453
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=9e3f07bd929c04ea873b05433521e6bd3da94b52
Submitter: Jenkins
Branch: master

commit 9e3f07bd929c04ea873b05433521e6bd3da94b52
Author: Maciej Kwiek <email address hidden>
Date: Wed May 20 12:14:33 2015 +0200

    Add field to release for storing valid deploy mode

    Field is called `modes`. Cluster validation stops creating the
    environment with mode that is not in the `modes` field of cluster
    release.

    One cluster validation test seemed to have reversed logic
    (test_release_non_exists_validation). It is fixed now.

    Change-Id: Iafeb988a91f44e29ea0491422b8348997d950bc4
    Closes-Bug: #1456540

[Maciej Kwiek (maciej-iai)]

This turned out to be a little tricky. It appeared that nailgun did not validate mode provided for environments at all, so I needed to add this validation to fuel-web. Fuelclient will fail as a consequence of change of validator, therefore no changes to client were needed.

[Egor Kotko (ykotko)]

{"build_id": "2015-05-24_15-51-50", "build_number": "462", "release_versions": {"2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-24_15-51-50", "build_number": "462", "api": "1.0", "fuel-library_sha": "889c2534ceadf8afd5d1540c1cadbd913c0c8c14", "nailgun_sha": "76441596e4fe6420cc7819427662fa244e150177", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce", "astute_sha": "0bd72c72369e743376864e8e8dabfe873d40450a", "fuel-ostf_sha": "9a5f55602c260d6c840c8333d8f32ec8cfa65c1f", "release": "6.1", "fuelmain_sha": "5c8ebddf64ea93000af2de3ccdb4aa8bb766ce93"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "889c2534ceadf8afd5d1540c1cadbd913c0c8c14", "nailgun_sha": "76441596e4fe6420cc7819427662fa244e150177", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce", "astute_sha": "0bd72c72369e743376864e8e8dabfe873d40450a", "fuel-ostf_sha": "9a5f55602c260d6c840c8333d8f32ec8cfa65c1f", "release": "6.1", "fuelmain_sha": "5c8ebddf64ea93000af2de3ccdb4aa8bb766ce93"}

Still can create env via cli with mode=multinode without any restriction and warnings

fuel env create --name=test2 --mode=multinode --network-mode nova --rel=1
DEPRECATION WARNING: /etc/fuel/client/config.yaml exists and will be used as the source for settings. This behavior is deprecated. Please specify the path to your custom settings file in the FUELCLIENT_CUSTOM_SETTINGS environment variable.
Warning: nova-network is deprecated since 6.1 release.
Environment 'test2' with id=2, mode=multinode and network-mode=nova_network was created!

[Maciej Kwiek (maciej-iai)]

The validation I added didn't work on PUT request. I am working on a patch to fix this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185383

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185383
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2f6d1626bae7927dcb680096db9885dc9c6c5ad5
Submitter: Jenkins
Branch: master

commit 2f6d1626bae7927dcb680096db9885dc9c6c5ad5
Author: Maciej Kwiek <email address hidden>
Date: Mon May 25 15:42:43 2015 +0200

    Add mode validation for cluster to PUT method

    The original fix did not work for validation while updating the cluster
    only with deployment mode, which is how the deployment mode is set via
    python-fuelclient.

    Change-Id: Id3dcbfd339db184ffe75ca8d06675195fe9486de
    Closes-Bug: #1456540

[Anastasia Palkina (apalkina)]

Verified on ISO #471

"build_id": "2015-05-26_20-59-56", "build_number": "471", "release_versions": {"2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-26_20-59-56", "build_number": "471", "api": "1.0", "fuel-library_sha": "8cfeca1a86179ebed1e4e03b2133b49c27350f6f", "nailgun_sha": "f737675091bd1903aace0e36812e855ce47dfec7", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce", "astute_sha": "0bd72c72369e743376864e8e8dabfe873d40450a", "fuel-ostf_sha": "87819878bc0ca572900e1f6933d9b99e666d6f62", "release": "6.1", "fuelmain_sha": "13b3e9cf074ba1cf1ae06509c55fbab613c73f4e"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "8cfeca1a86179ebed1e4e03b2133b49c27350f6f", "nailgun_sha": "f737675091bd1903aace0e36812e855ce47dfec7", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce", "astute_sha": "0bd72c72369e743376864e8e8dabfe873d40450a", "fuel-ostf_sha": "87819878bc0ca572900e1f6933d9b99e666d6f62", "release": "6.1", "fuelmain_sha": "13b3e9cf074ba1cf1ae06509c55fbab613c73f4e"

[OpenStack Infra (hudson-openstack)]

Change abandoned by Maciej Kwiek (<email address hidden>) on branch: master
Review: https://review.openstack.org/184425