OCF script ns_IPaddr2 does not interpolate variables

[Igor Zinovik]

Script must use $var name in square brackets, not 'var'.

https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/cluster/files/ocf/ns_IPaddr2#L302

https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/cluster/files/ocf/ns_IPaddr2#L319

https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/cluster/files/ocf/ns_IPaddr2#L391

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/183948

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/183948
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=297a5575573832ce37e643a4ddceeebb0c3dfd34
Submitter: Jenkins
Branch: master

commit 297a5575573832ce37e643a4ddceeebb0c3dfd34
Author: Bartłomiej Piotrowski <email address hidden>
Date: Sun May 17 22:48:26 2015 +0200

    Run test command against actual variables in ns_IPaddr2

    Change-Id: I29bffcbb441cc402ede64982054f6dd94b1c643c
    Closes-Bug: 1455961

[Artem Panchenko (apanchenko-8)]

fix was reverted https://github.com/stackforge/fuel-library/commit/a4aa1062e22c40a067e5e644b46d3a3512c260ae

[Matthew Mosesohn (raytrac3r)]

I see why it was bad and verted.. you can't run a test like this:
var=""
var2="something"
[ -z $var ]
[ -z $var2 ]
The first will just fail because $var is not encapsulated in quotes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226814

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226814
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3508d8bc3499f580205f32e5cdaf1dbbcedf7728
Submitter: Jenkins
Branch: master

commit 3508d8bc3499f580205f32e5cdaf1dbbcedf7728
Author: Matthew Mosesohn <email address hidden>
Date: Wed Sep 23 17:21:41 2015 +0300

    Interpolate vars in ns_IPaddr2 ocf

    Corrected all bash tests for zero and non-zero
    length vars. Corrected missing quotes when checking
    for netmask and ns string length.

    Renamed [[ to [ where appropriate for -n and -z tests.

    Change-Id: Ic83a406ab7681222679edee6688f4ba1aa0a19aa
    Closes-Bug: #1455961