Heat could not create samples with Ceilometer

Bug #1455421 reported by okamototk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Rico Lin
Kilo
Fix Released
Medium
Rico Lin

Bug Description

Heat could not create samples with Ceilometer.

I'm not expert but meter_xxx parameter seems wrong in Heat.
Following patch works for me.

--- watchrule.py.org 2015-05-15 17:48:38.351871774 +0900
+++ watchrule.py 2015-05-15 18:08:53.509800025 +0900
@@ -270,20 +270,20 @@
     def _to_ceilometer(self, data):
         clients = self.context.clients
         sample = {}
- sample['meter_type'] = 'gauge'
+ sample['counter_type'] = 'gauge'

         for k, d in iter(data.items()):
             if k == 'Namespace':
                 continue
- sample['meter_name'] = k
- sample['sample_volume'] = d['Value']
- sample['meter_unit'] = d['Unit']
+ sample['counter_name'] = k
+ sample['counter_volume'] = d['Value']
+ sample['counter_unit'] = d['Unit']
             dims = d.get('Dimensions', {})
             if isinstance(dims, list):
                 dims = dims[0]

okamototk (toraneko)
description: updated
affects: heat-templates → heat
Rico Lin (rico-lin)
Changed in heat:
assignee: nobody → Rico Lin (rico-lin)
Rico Lin (rico-lin)
Changed in heat:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/183901

Changed in heat:
status: Confirmed → In Progress
Revision history for this message
okamototk (toraneko) wrote :

I'm afraid, I use Juno. Could you fix this problem in Juno?

tags: added: juno-backport-potential kilo-backport-potential
Thomas Herve (therve)
Changed in heat:
milestone: none → liberty-1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/183901
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e4eeeed95a748715dac3a1752f82875966820c6d
Submitter: Jenkins
Branch: master

commit e4eeeed95a748715dac3a1752f82875966820c6d
Author: rico.lin <email address hidden>
Date: Sun May 17 16:17:40 2015 +0800

    Heat could not create samples with Ceilometer

    Heat could not create samples with Ceilometer, because ceilometer client has
    change some key words in CREATION_ATTRIBUTES which is using by create sample.

    Change-Id: I8e8dc80ae1b666ae74e2b2c2b757e7f468c25de2
    Closes-Bug: #1455421

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/195962

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/195972

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/juno)

Change abandoned by Rico Lin (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/195962

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/195972
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=18742d118669beba5efc03ee2dbf0449a414c418
Submitter: Jenkins
Branch: stable/kilo

commit 18742d118669beba5efc03ee2dbf0449a414c418
Author: rico.lin <email address hidden>
Date: Sun May 17 16:17:40 2015 +0800

    Heat could not create samples with Ceilometer

    Heat could not create samples with Ceilometer, because ceilometer client has
    change some key words in CREATION_ATTRIBUTES which is using by create sample.

    Change-Id: I8e8dc80ae1b666ae74e2b2c2b757e7f468c25de2
    Closes-Bug: #1455421
    (cherry picked from commit e4eeeed95a748715dac3a1752f82875966820c6d)

tags: added: in-stable-kilo
removed: kilo-backport-potential
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.