jobs using dkms_info script use it incorrectly, tests fail to run
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
Critical
|
Daniel Manrique |
Bug Description
I got this while trying to produce a test run to write the dkms parser.
The jobs call the command like this:
id: device_
plugin: attachment
command: dkms_info --format onelines
id: dkms_info_
plugin: attachment
command: dkms_info --dkms --format dumps
However, dkms_info claims not to support those options:
def register_
"""Register command line arguments for dkms-info."""
For starters there's clearly a bug in the --format parameter, which defaults to "onelines" but then claims only "summary" and "json" are valid options. I think the default should be "summary".
Next, the jobs need fixing to use "summary" instead of "onelines" and "json" instead of "dumps".
Next, the --dkms parameter is not defined anywhere at all. I don't know what this parameter is supposed to do.
And then, other places in the script (docstrings, comments) where the old parameters are mentioned also need to be fixed.
I'll need to triage this as critical because we need to have it fixed by next week before we start rolling out tools to the KH2 people. Luckily it looks like an easy fix :)
Related branches
- Zygmunt Krynicki (community): Approve
-
Diff: 97 lines (+1/-18)7 files modifiedproviders/plainbox-provider-certification-client/whitelists/client-cert-regression.whitelist (+0/-1)
providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist (+0/-1)
providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist (+0/-1)
providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist (+0/-1)
providers/plainbox-provider-checkbox/jobs/info.txt.in (+1/-12)
providers/plainbox-provider-checkbox/whitelists/autotesting.whitelist (+0/-1)
providers/plainbox-provider-checkbox/whitelists/hwsubmit.whitelist (+0/-1)
Changed in plainbox-provider-checkbox: | |
assignee: | nobody → Daniel Manrique (roadmr) |
status: | Triaged → In Progress |
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
milestone: | none → 0.21 |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |