taskmanager unittests contains an unmocked entry

Bug #1455125 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Sushil Kumar

Bug Description

https://github.com/openstack/trove/blob/master/trove/tests/unittests/taskmanager/test_models.py#L486 mocks taskmanager_models.CONF.get but does not unmocks it

This also goes un-noticed by the dangling mock detector.

Found it while writing other tests which involved trove.taskmanager.models.CONF

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/183084

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/183084
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=03c38b46ffa9ff1680271ebc5902da2e443f2264
Submitter: Jenkins
Branch: master

commit 03c38b46ffa9ff1680271ebc5902da2e443f2264
Author: Sushil Kumar <email address hidden>
Date: Thu May 14 15:33:26 2015 +0000

    Fixed the unmocked entry in taskmanager unit-tests

    Made use of patch.object to resolve the unmocking problem.

    Change-Id: I09a8f4bacaba2f409dc152f4f9b6dc1123f03131
    Closes-Bug: #1455125

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
importance: Undecided → High
Changed in trove:
milestone: none → liberty-1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-1 → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.