[systest] Re-factor methods which modify astute.yaml

Bug #1455015 reported by Artem Panchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Artem Panchenko

Bug Description

In system tests we modify a couple of settings stored in /etc/fuel/astute.yaml:

https://github.com/stackforge/fuel-qa/blob/master/fuelweb_test/helpers/fuel_actions.py#L118-L120
https://github.com/stackforge/fuel-qa/blob/master/fuelweb_test/helpers/fuel_actions.py#L135

In order to avoid issues like this bug #1454988 we should avoid using of 'sed' for that and use yaml load/dump. For example we have a method which loads settings from astute.yaml file:

https://github.com/stackforge/fuel-qa/blob/master/fuelweb_test/models/environment.py#L449

Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: MOS QA Team (mos-qa) → Fuel QA Team (fuel-qa)
Changed in fuel:
milestone: 7.0 → 8.0
Vasily Gorin (vgorin)
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Vasily Gorin (vgorin)
Vasily Gorin (vgorin)
Changed in fuel:
assignee: Vasily Gorin (vgorin) → Fuel QA Team (fuel-qa)
Dmitry Pyzhov (dpyzhov)
tags: added: area-qa
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/248499

Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Artem Panchenko (apanchenko-8)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/248499
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=1b67512152518fe43bdb2124d5ff9d3c5bdac3b3
Submitter: Jenkins
Branch: master

commit 1b67512152518fe43bdb2124d5ff9d3c5bdac3b3
Author: Artem Panchenko <email address hidden>
Date: Mon Nov 23 00:37:34 2015 +0200

    Use YAML methods for changing Fuel 'astute.yaml'

    Use load/dump methods for changing content of 'astute.yaml'
    while deploying Fuel master node.

    Change-Id: I71cb042927b912dd7b610cbaadca48919dafc47c
    Closes-bug: #1455015

Changed in fuel:
status: In Progress → Fix Committed
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.