KPAC Hold Notifications - SMS

[Terran McCanna]

This is a followup to LP#1282783 which was related to the KPAC not setting the patron's default hold notification preferences when a new hold is placed. The previous fix solved the problem if the library was only using email and phone notifications but did not take SMS text messages into account. I've reworked it to accommodate all three notification options and will post the code for review shortly.

Problem observed in Evergreen 2.7, 2.8

[Terran McCanna (tmccanna)]

Fix posted to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1454871_kpac_hold_notifications

[Heidi Florenzen (hflorenzen)]

Unable to test if default settings for SMS notices are applied when placing a hold in the KPAC. Fix creates an Internal Server Error when attempting to place a hold from the KPAC. Holds were successful on the same server using the TPAC and the staff client.

[Terran McCanna (tmccanna)]

Drat, I have it working in production, but I missed something when I tried to apply it to master. I will troubleshoot it.

[Terran McCanna (tmccanna)]

I removed the pullrequest tag since I need to work on it more.

[Terran McCanna (tmccanna)]

My apologies, I had an extra END tag in my earlier patch. I've redone it and it is working on my own sandbox:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1454871_kpac_hold_notifications_v2

Thanks in advance to whoever has a few moments to test it!

Terran

[Ben Shum (bshum)]

Rescuing this from getting too lost in the wild and assigning milestone targets for maintenance fixes.

[Josh Stompro (u-launchpad-stompro-org)]

I tested this against master and it works just like it should.

1. After install I enabled the SMS Notification YAOUS.
2. Set all notification options for a test patron.
3. Placed a hold in the kpac
4. Confirmed that the hold had all the notification options set, especially the Text Notification option.

Signoff Branch is at
working/user/stompro/lp1454871_kpac_hold_notifications_v2_signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1454871_kpac_hold_notifications_v2_signoff

[Galen Charlton (gmc)]

Pushed all the way to rel_2_8. Thanks, Terran!

One note: could you ensure that your text editor is set to use spaces rather than tabs? Only C code (and Makefiles) currently use literal tabs.

[Terran McCanna (tmccanna)]

Will do, thanks Galen.