TestUseLumberjack fails on windows

[Martin Packman]

CI windows unit test job is failing on the 1.24 branch:

<http://reports.vapour.ws/releases/2639/job/run-unit-tests-win2012-amd64/attempt/396>

Just one new test added that breaks:

<http://data.vapour.ws/juju-ci/products/version-2639/run-unit-tests-win2012-amd64/build-396/consoleText>

FAIL: unit_test.go:462: UnitSuite.TestUseLumberjack
...
unit_test.go:479:
    c.Check(l.Filename, gc.Equals, "/var/log/juju/machine-42.log")
... obtained string = "\\var\\log\\juju\\machine-42.log"
... expected string = "/var/log/juju/machine-42.log"

At the least the test needs to be aware of os path differences, and perhaps the actual code should have a better sense of where logs go than /var/log.

[Martin Packman (gz)]

Test introduced by this pull request:

<https://github.com/juju/juju/pull/2303>

So, also affects 1.23 though we don't run the unit tests against windows on that branch.

[Curtis Hovey (sinzui)]

The bad revsion was merged into master even though this bug was reported and the CI reported the failure.

[Jesse Meek (waigani)]

Proposed fix: http://reviews.vapour.ws/r/1683

[Canonical Juju QA Bot (juju-qa-bot)]

Juju-CI verified that this issue is Fix Released in juju-core 1.24:
    http://reports.vapour.ws/releases/2646

[Canonical Juju QA Bot (juju-qa-bot)]

Juju-CI verified that this issue is Fix Released in juju-core master:
    http://reports.vapour.ws/releases/2647