SolidFire update cache image overwrites accountID param variable

Bug #1454425 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
John Griffith

Bug Description

bug in the update cache volume in SolidFire driver on delete:

        else:
            # Bummer, it's been updated, delete it
            params = {'accountID': sfaccount['accountID']}
            params = {'volumeID': sf_vol['volumeID']}
            data = self._issue_api_request('DeleteVolume', params)
            if 'result' not in data:

s/ params = {'volumeID': sf_vol['volumeID']}/ params['volumeID'] = sf_vol['volumeID']/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/182471

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/182471
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cf4c885c20fb46672a758a6ec94e61346fa317cc
Submitter: Jenkins
Branch: master

commit cf4c885c20fb46672a758a6ec94e61346fa317cc
Author: John Griffith <email address hidden>
Date: Tue May 12 15:48:03 2015 -0600

    Fix overwrite of params in SF image cache update

    In the update cache volume routine of the SolidFire driver
    we're unintentionally re-initializing the params variable
    when assigning volID as opposed to just appending another key
    to it.

    This patch fixes that.

    Change-Id: I213776ee6aef6e5dee2807c19b7eea05af23d6c0
    Closes-Bug: #1454425

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.