glance unit tests fail with glance_store==0.5.0

[Soren Hansen]

glance_store 0.5.0 was released this morning. Unfortunately, it breaks glance's test suite.

Here's an example failure:

Traceback (most recent call last):
  File "glance/tests/unit/v2/test_registry_api.py", line 48, in setUp
    super(TestRegistryRPC, self).setUp()
  File "glance/tests/unit/base.py", line 61, in setUp
    super(IsolatedUnitTest, self).setUp()
  File "glance/tests/unit/base.py", line 38, in setUp
    self._create_stores()
  File "glance/tests/unit/base.py", line 49, in _create_stores
    store.create_stores(CONF)
  File "/home/buildbot/schmenkins/state/jobs/glance-upstream/workspace/.tox/py27/local/lib/python2.7/site-packages/glance_store/backend.
py", line 186, in create_stores
    store_instance.configure(re_raise_bsc=True)
  File "/home/buildbot/schmenkins/state/jobs/glance-upstream/workspace/.tox/py27/local/lib/python2.7/site-packages/glance_store/driver.p
y", line 72, in configure
    self.configure_add()
  File "/home/buildbot/schmenkins/state/jobs/glance-upstream/workspace/.tox/py27/local/lib/python2.7/site-packages/glance_store/_drivers
/filesystem.py", line 303, in configure_add
    reason=reason)
glance_store.exceptions.BadStoreConfiguration: Store filesystem could not be configured correctly. Reason: Specify at least 'filesystem_store_datadir' or 'filesystem_store_datadirs' option

It's pretty severe:

Ran 2699 tests in 864.327s
FAILED (id=0, failures=980, skips=14)
error: testr failed (1)
ERROR: InvocationError: '/home/buildbot/schmenkins/state/jobs/glance-upstream/workspace/.tox/py27/bin/lockutils-wrapper python setup.py testr --slowest --testr-args='

[Soren Hansen (soren)]

Putting "glance-store==0.4.0" in requirements makes it pass again.

[Louis Taylor (kragniz)]

Thanks for reporting this, Soren.

[Louis Taylor (kragniz)]

This was introduced in glance_store 63fcfd55c0dcb9d8b642fadf9dc2e98d82adef26

[Louis Taylor (kragniz)]

https://review.openstack.org/#/c/182469

[Stuart McLaren (stuart-mclaren)]

We've been seeing too many glance_store release issues like this.

We should consider blocking new glance_store releases until we make some improvements to our glance <-> glance_store testing.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/182469
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=2278bcff3b98c41d3cd67f7b34fc7ca93bd9066e
Submitter: Jenkins
Branch: master

commit 2278bcff3b98c41d3cd67f7b34fc7ca93bd9066e
Author: Louis Taylor <email address hidden>
Date: Tue May 12 22:40:34 2015 +0100

    Set filesystem_store_datadir in tests

    The new release of glance_store (0.5.0) included
    I1d4f95cba47d21f1eb7e580314d01ac8d3481586, which raises errors if
    filesystem_store_datadir or filesystem_store_datadirs is not set. Glance
    currently is not correctly populating either of those options in certain
    unit or functional tests, causing a lot of test failures. This patch
    aims to unblock the gate by overriding the CONF option.

    Change-Id: I3a9e0c7bfa4a9f38b41e93dce9652c4cc4811a9b
    Closes-Bug: #1454384