hildon menu popups in wrong location

Bug #145406 reported by cwong1
2
Affects Status Importance Assigned to Milestone
Midbrowser
Fix Released
Medium
Alexander Sack

Bug Description

Sometime the midbrowser menu popups in wrong location. To reprodcue the problem, do the following:

    1. open the midbrowser
    2. Right click in the browser window to bring up a context menu
    3. Close the context menu by click somewhere else in the window
    4. Now click on "Home" button at the top left.

You should see the midbrowser shows up in wrong location. The "y" coordinate is off by few pixels.

Carl

Revision history for this message
Alexander Sack (asac) wrote :

ok, i landed a layout engine workaround, which hopefully doesn't cause any regressions:

$ git diff HEAD^
diff --git a/layout/xul/base/src/nsMenuPopupFrame.cpp b/layout/xul/base/src/nsMenuPopupFrame.cpp
index fa26e28..952ba96 100644
--- a/layout/xul/base/src/nsMenuPopupFrame.cpp
+++ b/layout/xul/base/src/nsMenuPopupFrame.cpp
@@ -512,7 +512,7 @@ nsMenuPopupFrame::AdjustClientXYForNestedDocuments ( nsIDOMXULDocument* inPopupD
   nsCOMPtr<nsIDOMXULDocument2> doc = do_QueryInterface(inPopupDoc);
   if (mContent->Tag() == nsXULAtoms::tooltip)
     doc->TrustedGetTooltipNode(getter_AddRefs(targetNode));
- else
+ else if (mContent->Tag() == nsXULAtoms::popup)
     doc->TrustedGetPopupNode(getter_AddRefs(targetNode));

   //NS_WARN_IF_FALSE(targetNode, "no popup/tooltip node on document!");

Changed in midbrowser:
importance: Undecided → Medium
status: New → Fix Committed
assignee: nobody → asac
Revision history for this message
Alexander Sack (asac) wrote :

this was fixed in 0.1.6c release.

Changed in midbrowser:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.