Federation /protocols tests mistakenly use 'protocol_id' instead of 'id'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-keystoneclient |
Fix Released
|
Medium
|
Dolph Mathews |
Bug Description
The second paragraph of the keystone-wide API conventions asserts that "each resource contains a canonically unique identifier (ID) defined by the Identity service implementation and is provided as the id attribute":
https:/
Following in that spirit, the federation API specification asserts that every instance of a protocol reference should have an 'id' attribute which appears in the URL references as a 'protocol_id':
But the client unit tests create protocol references with a 'protocol_id' attribute instead of an 'id' attribute:
Fortunately, the server-side implementation appears to persist protocols correctly:
So, 'protocol_id' here should just be 'id', and all the dependent tests need to be revised:
Confirmed by Steve Martinelli.
tags: | added: test-improvement |
description: | updated |
Changed in python-keystoneclient: | |
milestone: | none → 1.4.0 |
Changed in python-keystoneclient: | |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/181945
Review: https:/