can't add/del parameter in nested stack during stack-update

[neil nie]

Looks like nested stack doesn't allow parameter change. It fails at
            after_props.validate()

Is it the inention to disable that since update_allowed_properties default is none?

But it's possible to allow that for nested stack, since it's special resource constructed by base resource.

2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource File "/opt/stack/venvs/openstack/local/lib/python2.7/site-packages/heat/engine/resource.py", line 439, in _action_recorder
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource yield
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource File "/opt/stack/venvs/openstack/local/lib/python2.7/site-packages/heat/engine/resource.py", line 688, in update
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource after_props.validate()
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource File "/opt/stack/venvs/openstack/local/lib/python2.7/site-packages/heat/engine/properties.py", line 375, in validate
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource raise exception.StackValidationFailed(message=msg)
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource StackValidationFailed: Unknown Property str_len
2015-05-08 04:07:08.164 18023 TRACE heat.engine.resource

Regards,
Neil

[jichenjc (jichenjc)]

I didn't see any thing related to nova, assume heat

[Rabi Mishra (rabi)]

IMO, this should be allowed i.e. allow to add/del properties to nested stack. Would like to know others views on this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/182763

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184850

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rabi Mishra (<email address hidden>) on branch: master
Review: https://review.openstack.org/184850
Reason: should be for kilo

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/184862

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/182763
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=141597f032a38fdd96c97c14c0517db9463dd9c9
Submitter: Jenkins
Branch: master

commit 141597f032a38fdd96c97c14c0517db9463dd9c9
Author: Rabi Mishra <email address hidden>
Date: Wed May 13 16:39:04 2015 +0530

    Fix property validation for TemplateResource during update

    This fix adds schema regeneration before props are validated
    for TemplateResource during stack-update.

    Change-Id: Ia79a25083489f48ed7332fbbd089a0090452cdc4
    Closes-Bug: #1452983
    Closes-Bug: #1453923

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/184862
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ed2bed2555c85dc8d830477194065654400c5627
Submitter: Jenkins
Branch: stable/kilo

commit ed2bed2555c85dc8d830477194065654400c5627
Author: Rabi Mishra <email address hidden>
Date: Wed May 13 16:39:04 2015 +0530

    Fix property validation for TemplateResource during update

    This fix adds schema regeneration before props are validated
    for TemplateResource during stack-update.

    Change-Id: Ia79a25083489f48ed7332fbbd089a0090452cdc4
    Closes-Bug: #1452983
    Closes-Bug: #1453923
    (cherry picked from commit 141597f032a38fdd96c97c14c0517db9463dd9c9)