prevent staff client warnings with Google Analytics

Bug #1452883 reported by Jason Etheridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.7
Fix Released
Undecided
Unassigned
2.8
Fix Released
Undecided
Unassigned

Bug Description

collab/phasefx/google_analytics @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=c4d74c7a00e70f88d05e158bb6d6d78bf7ccf130

commit c4d74c7a00e70f88d05e158bb6d6d78bf7ccf130
Author: Jason Etheridge <email address hidden>
Date: Thu May 7 16:02:00 2015 -0400

    prevent staff client warnings w/ Google Analytics

    In particular, the Security Warning that goes "You have requested an encrypted
    page that contains some unencrypted information..."

    Signed-off-by: Jason Etheridge <email address hidden>

Revision history for this message
Jason Etheridge (phasefx) wrote :

As a tangential feature or change in behavior, we may want to offer to not load Google Analytics within the staff client at all, or allow for a different code to be used.

Revision history for this message
Galen Charlton (gmc) wrote :

I suggest disabling Google Analytics outright in the staff client; there's far too much potential for leaking patron information.

Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I confirmed that I see this issue in Master. Enabled google analytics in template/opac/parts/config.tt2 and then loaded the catalog in the staff client and immediately saw the "You have requested an encrypted.....blah" popup error.

Using a system with the collab/phasefx/google_analytics branch I can confirm that I don't see that error anymore. Enabled google analytics. Confirmed that the code was showing up in the opac, and then loaded the catalog in the staff client and I saw no error message. I also double checked the page source in the staff client to make sure the GA code was there, and it was.

I have tested this code and consent to signing off on it with my name, Josh Stompro and email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master, rel_2_8, and rel_2_7

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.