LSB function status_of_proc missing PID argument in the initscript

[Caio Begotti]

It seems /lib/lsb/init-functions was always meant to be used with -p ${PID} otherwise it can wrongly guess the name of the process binary, which changed over the time for Capomastro I suppose otherwise this wouldn't have worked before as it was.

Without -p ${PID} "service capomastro status" will not check the right process and will probably return the wrong status of the service.

[Daniel Manrique (roadmr)]

So in debian/capomastro.init, change:

do_status () {
  status_of_proc "${DAEMON}" "Service ${NAME}"

  [ "${?}" = 2 ] && return 2
  return "${?}"
}

should change to (notice I'm also doing some return value storing):

do_status () {
  status_of_proc -p ${PIDFILE} "${DAEMON}" "Service ${NAME}"
  retval=${?}

  [ "${retval}" = 2 ] && return 2
  return "${retval}"
}

According to the /lib/lsb/init-functions code and other examples in /etc/init.d, it can be called with the pidfile (not necessarily the PID itself), which makes this a quite simple change.