Perms on /etc/swift/backups not handled correctly by ansible

Bug #1452743 reported by Andy McCrae
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Andy McCrae
Kilo
Fix Released
Medium
Andy McCrae
Trunk
Fix Released
Medium
Andy McCrae

Bug Description

Since we aren't managed /etc/swift/backups using ansible its possible that if the permissions are messed up (e.g. root:root) the plays will fail to rsync as below. (This was seen to happen when upgrading from juno - kilo/master)

TASK: [os_swift | Get swift rings]
********************************************
changed: [swift02]
changed: [infra03_swift_proxy_container-988be84b]
failed: [swift01] => {"changed": true, "cmd": "rsync -e 'ssh -o
UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no' -avz
swift@10.0.0.3:/etc/swift/ring_build_fi
les/ /etc/swift/", "delta": "0:00:00.177260", "end": "2015-05-05
22:44:43.049855", "rc": 23, "start": "2015-05-05 22:44:42.872595",
"warnings": ["Consider using synchronize mod
ule rather than running rsync"]}
stderr: Warning: Permanently added '10..0.13' (ECDSA) to the list of
known hosts.
rsync: failed to set times on "/etc/swift/backups": Operation not
permitted (1)
rsync error: some files/attrs were not transferred (see previous
errors) (code 23) at main.c(1655) [generator=3.1.0]
stdout: receiving incremental file list
backups/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/181011

Changed in openstack-ansible:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/181012

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/181011
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=87d48cd4e26fec3ac062a1543ce62c8ce0ee3e54
Submitter: Jenkins
Branch: master

commit 87d48cd4e26fec3ac062a1543ce62c8ce0ee3e54
Author: Andy McCrae <email address hidden>
Date: Thu May 7 15:16:22 2015 +0100

    Managed /etc/swift/backups using ansible

    If the permissions on /etc/swift/backups are not swift.swift it can
    cause the copying of the ring files to fail.

    This patch adds /etc/swift/backups to the list of directories managed by
    ansible when setting up/configuring swift.

    Change-Id: I3937efc54f03e25f504937213a99bde19789aa59
    Closes-Bug: #1452743

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/181012
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=519194e47d586c91cd754f54933c88be90813265
Submitter: Jenkins
Branch: kilo

commit 519194e47d586c91cd754f54933c88be90813265
Author: Andy McCrae <email address hidden>
Date: Thu May 7 15:16:22 2015 +0100

    Managed /etc/swift/backups using ansible

    If the permissions on /etc/swift/backups are not swift.swift it can
    cause the copying of the ring files to fail.

    This patch adds /etc/swift/backups to the list of directories managed by
    ansible when setting up/configuring swift.

    Change-Id: I3937efc54f03e25f504937213a99bde19789aa59
    Closes-Bug: #1452743
    (cherry picked from commit 87d48cd4e26fec3ac062a1543ce62c8ce0ee3e54)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.11

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.12

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.