flashsystem vdiskmap exists/object does not exist while running tests with multi-thread

[Edwin Wang]

We have encountered an issue when running tests with multi-thread:

Case 1:
2015-05-07 20:35:15.544 ERROR cinder.volume.drivers.ibm.flashsystem [req-d55d1114-9ed0-4475-81c4-0ed90540fe47 SnapshotsActionsV1Test-1280266722] _map_vdisk_to_host: Failed with unexpected CLI output.
 Command: ['svctask', 'mkvdiskhostmap', '-host', u'stack-02-03159190', '-scsi', u'12', u'snapshot-4811b2da-68db-4ae2-a2e8-b9f16d84e2d2']
 stdout:
 stderr: CMMVC5879E The VDisk-to-host mapping was not created because a VDisk is already mapped to this host with this SCSI LUN.
2015-05-07 20:35:15.545 ERROR cinder.volume.drivers.ibm.flashsystem [req-d55d1114-9ed0-4475-81c4-0ed90540fe47 SnapshotsActionsV1Test-1280266722] _copy_vdisk_data: Failed to copy volume-7bedce90-9ff1-4e50-83f1-8466a9ef0474 to snapshot-4811b2da-68db-4ae2-a2e8-b9f16d84e2d2.

Case 2:
2015-05-07 20:43:40.878 ERROR cinder.volume.drivers.ibm.flashsystem [req-320da549-8ade-45a2-abd7-aa459211a441 None] _map_vdisk_to_host: Failed with unexpected CLI output.
 Command: ['svctask', 'mkvdiskhostmap', '-host', u'stack-02-03159190', '-scsi', u'11', u'volume-d720181c-5f52-4b77-9255-98be45a59c19']
 stdout:
 stderr: CMMVC5879E The VDisk-to-host mapping was not created because a VDisk is already mapped to this host with this SCSI LUN.

2015-05-07 20:43:40.879 ERROR cinder.volume.manager [req-320da549-8ade-45a2-abd7-aa459211a441 None] [volume-d720181c-5f52-4b77-9255-98be45a59c19] (u'Driver initialize connection failed (error: %(err)s).', {'err': u"Bad or unexpected response from the storage volume backend API: _map_vdisk_to_host: Failed with unexpected CLI output.\n Command: ['svctask', 'mkvdiskhostmap', '-host', u'stack-02-03159190', '-scsi', u'11', u'volume-d720181c-5f52-4b77-9255-98be45a59c19']\n stdout: \n stderr: CMMVC5879E The VDisk-to-host mapping was not created because a VDisk is already mapped to this host with this SCSI LUN.\n"})

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/181285

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/181285
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4e3259e9f1bdcd0b5d274ca39c603fc8ad7536f1
Submitter: Jenkins
Branch: master

commit 4e3259e9f1bdcd0b5d274ca39c603fc8ad7536f1
Author: Edwin Wang <email address hidden>
Date: Fri May 8 11:00:01 2015 +0800

    FlashSystem reports error while running tests with multi-thread

    There was an issue while running initialize_connection/
    terminate_connection/_map_vdisk_to_host/_unmap_vdisk_from_host in
    parallel threads.

    This fix adds lock into these functions and removes incorrect
    timer.stop().

    Change-Id: If433522bc7799e16a918ba7c5b300b7333e430a8
    Close-bug: 1452721

[Edwin Wang (edwin-wang)]

Test passed with 4 threads.