OpenStack Heat

Changing paths in env are ignored when updating a template resource

Bug #1452534 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Zane Bitter
OpenStack Heat 5.0.0 "liberty"
Juno
Fix Released
High
Crag Wolfe
OpenStack Heat 2014.2.4
Kilo
Fix Released
High
Zane Bitter
OpenStack Heat 2015.1.1

Bug Description

If the path to the template for a template/facade/provider resource changes during a stack update, the template of the provider stack will not be updated.

Note that this path can change even without modifying the environment file if the base directory containing the files is moved on disk. This is because python-heatclient rewrites the filenames to file:// URLs with absolute paths.

This bug was hidden by bug 1452520, which caused the failure to find the template to be silent.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180843

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/180849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/180853

Changed in heat:
assignee: Zane Bitter (zaneb) → Steve Baker (steve-stevebaker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/180843
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=686f317ccae280bd8b536379e89ba743746ae159
Submitter: Jenkins
Branch: master

commit 686f317ccae280bd8b536379e89ba743746ae159
Author: Zane Bitter <email address hidden>
Date: Wed May 6 21:29:25 2015 -0400

    Update template paths for environment-mapped TemplateResources

    When updating a template resource, we weren't taking into account the
    possibility that the new environment could be mapping the resource to a
    different template path. This change ensures we recalculate the template
    name from the new environment before reloading the template during an
    update.

    Change-Id: I5f84f6fd60925d3dba0b8e8dec867657c8c5c9ef
    Closes-Bug: #1452534

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Steve Baker (<email address hidden>) on branch: master
Review: https://review.openstack.org/180853
Reason: alternative test merged https://review.openstack.org/#/c/180847/4

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Steve Baker (<email address hidden>) on branch: master
Review: https://review.openstack.org/180849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/181992

Zane Bitter (zaneb)
Changed in heat:
assignee: Steve Baker (steve-stevebaker) → Zane Bitter (zaneb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/181992
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=aa4b90df9d608cdfd6459f1af17556de925519b1
Submitter: Jenkins
Branch: stable/kilo

commit aa4b90df9d608cdfd6459f1af17556de925519b1
Author: Zane Bitter <email address hidden>
Date: Wed May 6 21:29:25 2015 -0400

    Update template paths for environment-mapped TemplateResources

    When updating a template resource, we weren't taking into account the
    possibility that the new environment could be mapping the resource to a
    different template path. This change ensures we recalculate the template
    name from the new environment before reloading the template during an
    update.

    Co-Authored-By: Angus Salkeld <email address hidden>
    Change-Id: I5f84f6fd60925d3dba0b8e8dec867657c8c5c9ef
    Closes-Bug: #1452534
    (cherry picked from commits 686f317ccae280bd8b536379e89ba743746ae159 and
                                8c37b56acef04178e07591eecde27a50f7ef5ac9)

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Steve Baker (steve-stevebaker)
tags: added: in-stable-kilo
removed: kilo-backport-potential
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/243864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/243864
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e62752f4b9cd6ffd116bfb6edbaefeb35958c2fa
Submitter: Jenkins
Branch: stable/juno

commit e62752f4b9cd6ffd116bfb6edbaefeb35958c2fa
Author: Zane Bitter <email address hidden>
Date: Wed May 6 21:29:25 2015 -0400

    Update template paths for environment-mapped TemplateResources

    When updating a template resource, we weren't taking into account the
    possibility that the new environment could be mapping the resource to a
    different template path. This change ensures we recalculate the template
    name from the new environment before reloading the template during an
    update.

    Change-Id: I5f84f6fd60925d3dba0b8e8dec867657c8c5c9ef
    Closes-Bug: #1452534
    (cherry picked from commit 686f317ccae280bd8b536379e89ba743746ae159)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.