nova-api: remove unuseful expect error in v2.1 service delete method

Bug #1452522 reported by Eli Qiao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Eli Qiao

Bug Description

in nova/api/openstack/compute/plugins/v3/services.py
we found :
    @extensions.expected_errors((400, 404))
     def delete(self, req, id):

by checking code, there isn't any badrequest exception raising,
we need to remove 400 from expected code.

Tags: api
Eli Qiao (taget-9)
Changed in nova:
assignee: nobody → Eli Qiao (taget-9)
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180827

Changed in nova:
status: New → In Progress
Alex Xu (xuhj)
Changed in nova:
importance: Undecided → Low
Changed in nova:
assignee: Eli Qiao (taget-9) → Alex Xu (xuhj)
Changed in nova:
assignee: Alex Xu (xuhj) → Eli Qiao (taget-9)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/180827
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bcb9769356bac6e9da7aa81b92affd61f9963c8c
Submitter: Jenkins
Branch: master

commit bcb9769356bac6e9da7aa81b92affd61f9963c8c
Author: Eli Qiao <email address hidden>
Date: Thu May 7 09:51:30 2015 +0800

    API: remove unuseful expected error code from v2.1 service delete api

    There isn't any BadRequest exception raise from this api method.
    Remove it.

    DOCImpact: service delete will not raise 400.
    Closes-Bug: #1452522

    Change-Id: Iad489926176aa5ebf4ab914f1ba6e4546e913fc5

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.