Set up global proxy environment variables from user variable

Bug #1452456 reported by Ian Cordasco
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Wishlist
Ian Cordasco
Juno
Fix Released
Wishlist
Hugh Saunders
Kilo
Fix Released
Wishlist
Ian Cordasco
Trunk
Fix Released
Wishlist
Ian Cordasco

Bug Description

For users deploying from behind a proxy, pip (and requests) needs to know what those proxies are. It would be useful to have a variable that can be configured to automatically configure the HTTP_PROXY and HTTPS_PROXY environment variables. pip and the python clients will respect these variables as necessary. Defining these on the hosts and containers should be a common task only when the user variable is defined.

Revision history for this message
Ian Cordasco (icordasc) wrote :

We should also, at the same time, calculate a NO_PROXY environment variable. We should probably add to that, the container network CIDR, and a few other IPs/hosts (localhost, etc) that we know we won't need to talk to the proxy for since they're internal only.

Ian Cordasco (icordasc)
Changed in openstack-ansible:
assignee: nobody → Ian Cordasco (icordasc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/181603

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/181603
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=ed7f78ea5689769b3a5e1db444f4c16f3cc06060
Submitter: Jenkins
Branch: master

commit ed7f78ea5689769b3a5e1db444f4c16f3cc06060
Author: Ian Cordasco <email address hidden>
Date: Fri May 8 16:47:27 2015 -0500

    Handle proxies through environment variables

    When running os-ansible-deployment on a cluster siting behind a proxy,
    users may need to set up special variables for proxies so that pip, and
    the services all work as expected.

    Closes-bug: 1452456
    Change-Id: I2a397abad6557a48bc737dcd9cca787fc5afa728

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/186868

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/186868
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=6bbec6aa2b338a409d11497f8d94057525f68a70
Submitter: Jenkins
Branch: kilo

commit 6bbec6aa2b338a409d11497f8d94057525f68a70
Author: Ian Cordasco <email address hidden>
Date: Fri May 8 16:47:27 2015 -0500

    Handle proxies through environment variables

    When running os-ansible-deployment on a cluster siting behind a proxy,
    users may need to set up special variables for proxies so that pip, and
    the services all work as expected.

    Closes-bug: 1452456
    Change-Id: I2a397abad6557a48bc737dcd9cca787fc5afa728
    (cherry picked from commit ed7f78ea5689769b3a5e1db444f4c16f3cc06060)

Revision history for this message
Darren Birkett (darren-birkett) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (juno)

Reviewed: https://review.openstack.org/192717
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=36391a4f7e99d3901117ac4712c71c5eeae71e4a
Submitter: Jenkins
Branch: juno

commit 36391a4f7e99d3901117ac4712c71c5eeae71e4a
Author: Hugh Saunders <email address hidden>
Date: Wed Jun 17 11:37:26 2015 +0100

    Handle proxies through environment variables

    When running os-ansible-deployment on a cluster siting behind a proxy,
    users may need to set up special variables for proxies so that pip, and
    the services all work as expected.

    Closes-bug: 1452456
    Change-Id: I2a397abad6557a48bc737dcd9cca787fc5afa728
    (cherry picked with modification from commit
    ed7f78ea5689769b3a5e1db444f4c16f3cc06060)

Revision history for this message
James Thorne (james-thorne) wrote :

The lower case variants of http_proxy and https_proxy also need to be added to the user_variables.yml file.

I encountered an issue with a customer yesterday where any Ansible module using the get_url core module would not honor the upper case HTTP_PROXY and HTTPS_PROXY environment variables. Once the lower case variants were added, the Ansible tasks completed.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.