iproute_arg_supported in neutron/agent/linux/ip_lib.py causes error logs when they should be debug

Bug #1452425 reported by Matthew Thode
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Matthew Thode

Bug Description

this function calls help. calling help typically causes the program being called to exit non-zero. This causes the command to be logged as an error even though it should not be.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180709

Changed in neutron:
assignee: nobody → Matthew Thode (prometheanfire)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/180709
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd9129d42cf280458301d5101a131c4c5c12abdf
Submitter: Jenkins
Branch: master

commit dd9129d42cf280458301d5101a131c4c5c12abdf
Author: Matthew Thode <email address hidden>
Date: Wed May 6 14:39:20 2015 -0500

    changes log level to debug for help calls

    Calling help typically causes the program being called to exit non-zero.
    This causes the command to be logged as an error even though it should not be.
    By setting 'log_fail_as_error=False' we log to debug. This helps clean
    up logs.

    Change-Id: I13f9488b9bc524bb85047e9b2dcf4e8a76bd6c11
    Closes-Bug: 1452425

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (neutron-pecan)

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.