TPAC: coded values labels can come from wrong locale

[Galen Charlton]

The R/O object cache used to store various values for use by TPAC templates hangs on to the locale that was in effect the first time the it was initialized for a particular Apache backend process. This means that (for example) coded value map entries for the OPAC material format attributes can display en-US labels even when the user session is in (say) fr-CA.

This can be reproduced as follows:

[1] Enable both en-US and fr-CA. Make sure that there are some translations for record format coded values in place as well.
[2] Run Apache in single-process mode (e.g., ". /etc/apache2/envvars && apache2 -X")
[3] Visit a record details page in the en-US locale. Note the label associated with the record format.
[4] Change the locale to fr-CA. Note that the label is still the English version.

Evergreen master

[Galen Charlton (gmc)]

A patch is available in the user/gmcharlt/lp1452352_fix_locale_awareness_of_ro_objects_cached_by_tpac branch of the Evergreen working repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1452352_fix_locale_awareness_of_ro_objects_cached_by_tpac

[Galen Charlton (gmc)]

Rather, *two* patches are available on that branch.

[Galen Charlton (gmc)]

I've pushed a follow-up patch, so there are now three.

[Bill Erickson (berick)]

Bug and fix confirmed. This seems like a bug fix to me (i.e. back-portable), but the code is fairly tightly integrated with new feature code (bug #1452366 and bug #1449709). I'm guessing we just want to merge the entire set to master only?

[Bill Erickson (berick)]

Merged to master. Thanks.