[SRU] Wrong input results

Bug #1452326 reported by Mathieu Bridon
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
libcangjie (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned
Utopic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

Ubuntu Trusty and Utopic are currently shipping some older versions of libcangjie, which have some known issues.

Those are fixed in libcangjie 1.3, which is already in Vivid.

Trusty currently ships libcangjie 1.0, and Utopic has 1.1.

Moving from 1.0 to 1.3 implies no API/ABI break. (I even checked that with abidiff, just to be sure)

The full release notes are available at this link:
    https://github.com/Cangjians/libcangjie/releases

As one of the upstream developers for libcangjie, I'd prefer you just updated to the latest upstream release in both Trusty and Utopic, but I can understand this might not be the proper process in Ubuntu, so I'll be more than happy to work with you to review differences, help backport patches, or anything else which could help.

At the very least, user experience would be vastly improved by just applying the following patches to the Ubuntu packages, both in Trusty and Utopic:

* https://github.com/Cangjians/libcangjie/commit/5e2abdb2f9dd122efd543307b7a1e2449943ca7d.patch
* https://github.com/Cangjians/libcangjie/commit/f363e39fdb738d4d393250db46e8db5c90d28132.patch
* https://github.com/Cangjians/libcangjie/commit/f48bb13fb55d28d1e5773686ab1d828fa456942f.patch
* https://github.com/Cangjians/libcangjie/commit/18c82a9620b861ee2c1ff698da717de2fcad126f.patch
* https://github.com/Cangjians/libcangjie/commit/3528d4abbae878e7a7056c3a5142c339ec01f31a.patch
* https://github.com/Cangjians/libcangjie/commit/cfb40d51e3365a52a98c1f5eb36380d3cb81e62c.patch
* https://github.com/Cangjians/libcangjie/commit/b5a37eae948ab8dbcb105723ab7313e465651e4e.patch

These are all **data** fixes, no code changes. Getting this data fixed in Ubuntu packages means that users will get the results they are expecting when typing Chinese with IBus Cangjie.

These data fixes are important for Hong Kong users, who in majority use a Cangjie input method. Most of them tend to run the latest LTS, which is why I'd really like to have these fixes pushed all the way back to Trusty.

The rest of the changes between 1.0 and 1.3 are minor and don't have any impact for users, so I won't be mad if you chose not to get them. :)

[Test Case]

1. install the package, as well as ibus-cangjie
2. configure the ibus-cangjie input method
3. type some cangjie codes, for example:
 * "raiu" gives no result with the current Trusty/Utopic package, but it should return 嘅 with the above patches
 * "okrx" returns 佑 with the current Trusty/Utopic package, but it should return 知 with the above patches

[Regression Potential]

I can't think of any, especially if you only apply the data fixes I listed above.

Also, note that this is quite a leaf-ish package: as far as I know, only pycangjie and ibus-cangjie depend on it. (for which I am also upstream)

Finally, this is quite a niche package: it is only useful to desktop users who need to type Chinese with a Cangjie input method (that's mostly Hong Kong, and some in Taiwan) in IBus.

So all in all, this should be a very safe update.

no longer affects: libcangjie (Ubuntu Vivid)
Changed in libcangjie (Ubuntu):
status: New → Fix Released
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in libcangjie (Ubuntu Trusty):
status: New → Confirmed
Changed in libcangjie (Ubuntu Utopic):
status: New → Confirmed
Hill Ma (hill-ma)
summary: - Wrong input results
+ [SRU] Wrong input results
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Note that the packaging has some Priority changes + an additional Conflicts. Both shouldn't create any issue and so, I kept them to stay aligned with latest debian's packaging.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Mathieu, or anyone else affected,

Accepted libcangjie into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libcangjie/1.3-1~utopic1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libcangjie (Ubuntu Utopic):
status: Confirmed → Fix Committed
tags: added: verification-needed
Changed in libcangjie (Ubuntu Trusty):
status: Confirmed → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Mathieu, or anyone else affected,

Accepted libcangjie into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libcangjie/1.3-1~trusty1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Mathieu Bridon (bochecha) wrote :

Confirming that the proposed package for Trusty fixes the issues.

Revision history for this message
Mathieu Bridon (bochecha) wrote :

Sorry, my above comment was for Utopic, I'm still testing Trusty.

Revision history for this message
Mathieu Bridon (bochecha) wrote :

Confirming that the proposed package for Trusty also fixes the issues.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libcangjie - 1.3-1~trusty1

---------------
libcangjie (1.3-1~trusty1) trusty; urgency=medium

  * Backporting vivid release sync to trusty to fix wrong input results
    as per upstream's request (LP: #1452326)

 -- Didier Roche <email address hidden> Tue, 26 May 2015 09:14:36 +0200

Changed in libcangjie (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for libcangjie has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libcangjie - 1.3-1~utopic1

---------------
libcangjie (1.3-1~utopic1) utopic; urgency=medium

  * Backporting vivid release sync to utopic to fix wrong input results
    as per upstream's request (LP: #1452326)

 -- Didier Roche <email address hidden> Tue, 26 May 2015 09:14:36 +0200

Changed in libcangjie (Ubuntu Utopic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.