Suspend and snapshot doesn't work for SR-IOV

[Aviram Bar-Haim]

Upstream bug: https://bugs.launchpad.net/nova/+bug/1406486

This backported bug is not in nova-compute package: https://review.openstack.org/#/c/164713/ .
This blocks suspend and snapshot capabilities for SR-IOV.

[Bogdan Dobrelya (bogdando)]

This is about to backport the upstream patch for MOS Nova, nothing could be done at puppet library side

[Roman Podoliaka (rpodolyaka)]

this breaks Mellanox, raising priority to High, so that we can formally fix this in 6.1

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.1/2014.2
Change author: Moshe Levi <email address hidden>
Review: https://review.fuel-infra.org/6468

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.0.1/2014.2
Change author: Moshe Levi <email address hidden>
Review: https://review.fuel-infra.org/6469

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/6468
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-6.1/2014.2

Commit: 24c60d19f7102f22daf4632b81004240de20d7b9
Author: Moshe Levi <email address hidden>
Date: Thu May 7 12:20:39 2015

Fix detach_sriov_ports to get context to be able to get image metadata

The previous implementation took the context using
get_admin_context() which return context with admin flag set,
but all the other attributes are None.
This is not sufficient to get image metadata,
it is need context with elevated permission.
The change here is to update API to pass the context to suspend so
it will be able to pass it to detach_sriov_ports.
Also update the snapshot method to pass context to detach_sriov_ports

(cherry picked from commit 6f002d26f28998c99d9922fdd49b0805c44ff22f)

Closes-Bug: #1452294
Change-Id: I4757a7646d7bee66db03c5d2410de7378c039d41

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/6469
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-6.0.1/2014.2

Commit: f8f667dc5a59ae7fb40a5a3704b10b408c8c0063
Author: Moshe Levi <email address hidden>
Date: Fri May 8 12:42:45 2015

Fix detach_sriov_ports to get context to be able to get image metadata

The previous implementation took the context using
get_admin_context() which return context with admin flag set,
but all the other attributes are None.
This is not sufficient to get image metadata,
it is need context with elevated permission.
The change here is to update API to pass the context to suspend so
it will be able to pass it to detach_sriov_ports.
Also update the snapshot method to pass context to detach_sriov_ports

(cherry picked from commit 6f002d26f28998c99d9922fdd49b0805c44ff22f)

Closes-Bug: #1452294
Change-Id: I4757a7646d7bee66db03c5d2410de7378c039d41

[Nastya Urlapova (aurlapova)]

@Aviram, can you verify this issue on your env?

[Aviram Bar-Haim (aviramb)]

Nastya, verified that files includes the required backport on our env. we need an ISO with a fix for https://bugs.launchpad.net/fuel/+bug/1456605 in order to fully check the capabilities for SR-IOV.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.0-updates/2014.2
Change author: Alex Ermolov <email address hidden>
Review: https://review.fuel-infra.org/7524

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7524
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-6.0-updates/2014.2

Commit: ef600046a80059cde055159d0e2ba7af54932134
Author: Alex Ermolov <email address hidden>
Date: Thu Jun 4 16:16:52 2015

Fix detach_sriov_ports to get context to be able to get image metadata

The previous implementation took the context using
get_admin_context() which return context with admin flag set,
but all the other attributes are None.
This is not sufficient to get image metadata,
it is need context with elevated permission.
The change here is to update API to pass the context to suspend so
it will be able to pass it to detach_sriov_ports.
Also update the snapshot method to pass context to detach_sriov_ports

Closes-Bug: #1452294
Change-Id: I4757a7646d7bee66db03c5d2410de7378c039d41

[Eugene Korekin (ekorekin)]

I verified this on MOS 7.0 and the bug isn't reproducible with our SR-IOV enabled Intel NICs (Intel Corporation 82599ES 10-Gigabit SFI/SFP+):

# neutron port-create net04 --binding:vnic-type direct --device_owner nova-compute --name sriov-port1
# port_id=`neutron port-list | awk '/sriov-port1/ {print $2}'`
# nova boot --flavor m1.small.sriov --image trusty --key_name key1 --nic port-id=$port_id sriov-vm1
# nova suspend sriov-vm1
# nova list

+--------------------------------------+-----------+-----------+------------+-------------+---------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+-----------+------------+-------------+---------------------+
| 3151be8c-5c8d-4e83-93b8-2ea3bad15d58 | sriov-vm1 | SUSPENDED | - | Shutdown | net04=192.168.111.4 |
+--------------------------------------+-----------+-----------+------------+-------------+---------------------+

# nova resume sriov-vm1
# nova list
+--------------------------------------+-----------+--------+------------+-------------+---------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+------------+-------------+---------------------+
| 3151be8c-5c8d-4e83-93b8-2ea3bad15d58 | sriov-vm1 | ACTIVE | - | Running | net04=192.168.111.4 |
+--------------------------------------+-----------+--------+------------+-------------+---------------------+

# nova image-create sriov-vm1 sriov-vm1-s1
# nova list
+--------------------------------------+-----------+--------+-----------------+-------------+---------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+-----------------+-------------+---------------------+
| 3151be8c-5c8d-4e83-93b8-2ea3bad15d58 | sriov-vm1 | ACTIVE | image_uploading | Running | net04=192.168.111.4 |
+--------------------------------------+-----------+--------+-----------------+-------------+---------------------+