Collectors message contains bad names

[Albert Einstein]

To reproduce:

1. Begin the game in Collectors mode in any language (including English!)
2. Wait for the first message
3. Read

You will see that the names should be (for example) "Wood lance", not "wood_lance". In other languages it would be "Drewniana lanca" instead of "wood_lance".

So the names are hardcoded, not taken from wares names.

[Hans Joachim Desserud (hjd)]

Thanks for reporting.

I see the same thing here with r7453.

>So the names are hardcoded, not taken from wares names.

Sorta. Wares have two names, an internal one and a display name. The internal name is always the same so it can be uniquely identified and compared regardless of language chosen. The display name is the translatable one which is (or should at least) be shown in the currently selected language.

For any text shown to players, including these messages the display names should be used. I'm fairly sure this used to be the case too.

[GunChleoc (gunchleoc)]

We only added the functionality to get at the display name for wares etc. when we automated the building help. So, this bug has always been there, but it's easy to fix. Thanks for reporting :)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.