Identify type of bgp-router objects explicitly

Bug #1451958 reported by Nischal Sheth
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
Medium
Ignatious Johnson Christopher
Trunk
Fix Committed
Medium
Ignatious Johnson Christopher

Bug Description

Terminology used here assumes that bug 1447273 has been addressed.

Current implementation uses the vendor field (value is "contrail") in
BgpRouterParams to identify control nodes. This is limiting when we
want to allow peering from control node in one cluster to a control
node in another cluster.

Proposal is to fix this by adding a new field called router-type to
BgpRouterParams to explicitly identify the type of bgp-router object.
There will be 3 types defined for now:

- Control Node: Control node in the local contrail cluster
- External Control Node: Control node in another contrail cluster
- Router: A regular BGP router such as MX, vMX, ASR9K

New version of UI code needs to set router-type to appropriate value as
described above when creating/editing a bgp-router. The vendor id should
be automatically set to contrail for router-type Control Node and External
Control Node. It can be configured by user for a Router.

The address family configuration for External Control Node should be same
as that for Control Nodes. IOW, the following families should be enabled
by default: route-target, inet-vpn, inet6-vpn, e-vpn and erm-vpn. There's
no change to the address families for a Router.

On a software upgrade/restart, API server will read all bgp-router objects
from the DB and set the router-type if it's not already set. If the vendor
is contrail, set router-type to Control Node, otherwise set it to Router.

Tags: config ui
Nischal Sheth (nsheth)
description: updated
Nischal Sheth (nsheth)
summary: - Identify bgp-router objects for in-cluster control nodes explicitly
+ Identify type of bgp-router objects explicitly
Nischal Sheth (nsheth)
description: updated
Nischal Sheth (nsheth)
description: updated
Nischal Sheth (nsheth)
description: updated
Nischal Sheth (nsheth)
description: updated
description: updated
Nischal Sheth (nsheth)
no longer affects: juniperopenstack/r2.20
Revision history for this message
Ignatious Johnson Christopher (ijohnson-x) wrote :
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/18867
Submitter: Ignatious Johnson Christopher (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/18895
Submitter: Ignatious Johnson Christopher (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/18867
Committed: http://github.org/Juniper/contrail-controller/commit/7eef0300529f1512d518348b2de291772d14ebc5
Submitter: Zuul
Branch: master

commit 7eef0300529f1512d518348b2de291772d14ebc5
Author: Ignatious Johnson Christopher <email address hidden>
Date: Wed Mar 30 00:29:40 2016 +0000

During software upgrade/restart, API server should read all bgp-router objects
from the DB and set the router-type if it's not already set. If the vendor
is contrail, setting router-type to Control Node, otherwise setting it to Router.

Change-Id: Ieac3a7d6de31a2d3dd0937332cd9d67cacb8143d
Closes-Bug: 1451958

Changed in juniperopenstack:
milestone: none → r3.1.0.0-fcs
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/18895
Committed: http://github.org/Juniper/contrail-controller/commit/33dbcc8a4b1bb9ff8449d88f1015e8ec036f9504
Submitter: Zuul
Branch: R3.0

commit 33dbcc8a4b1bb9ff8449d88f1015e8ec036f9504
Author: Ignatious Johnson Christopher <email address hidden>
Date: Wed Mar 30 00:29:40 2016 +0000

During software upgrade/restart, API server should read all bgp-router objects
from the DB and set the router-type if it's not already set. If the vendor
is contrail, setting router-type to Control Node, otherwise setting it to Router.

Change-Id: Ieac3a7d6de31a2d3dd0937332cd9d67cacb8143d
Closes-Bug: 1451958

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.