Console tokens are not correctly cleaned when destroy instance from host

Bug #1451801 reported by Sahid Orentino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sahid Orentino

Bug Description

There are two cases when we need to clean console tokens for an instance:

1/ When destroy the instance
2/ When migrate the instance

For the case 1 the current code base does not clean tokens when only rdp or only serial console is enable.
  http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n917

For the case 2 the current code base does not clean tokens when only serial console is enable.
  http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n5413

Nice to have: One private method to clean tokens

Changed in nova:
assignee: nobody → sahid (sahid-ferdjaoui)
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/179014
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a92fa5ac83c2c433fe989bea136ba92e88a2ab8a
Submitter: Jenkins
Branch: master

commit a92fa5ac83c2c433fe989bea136ba92e88a2ab8a
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Thu Apr 30 06:00:29 2015 -0400

    console: clean tokens do not happen for all kind of consoles

    The current condition to verify whether or not consoles are
    enable and so flush tokens when destroying instance is not
    kept sync with every kind of consoles that can be enable.

    This commit create one entry point to clean tokens + update the
    missing serial console config.

    Already covered by tests.

    Closes-Bug: #1451801
    Change-Id: Ie7cb03a9431549df75d7fbc82cf19e3f8f410a0f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.