Bug #1451797 “rc.local should require network-online.target” : Bugs : systemd package : Ubuntu

Revision history for this message

Dr. Jens Harbott (j-harbott) wrote on 2015-05-05:

#1

CurrentDmesg.txt Edit (82.7 KiB, text/plain; charset="utf-8")
Dependencies.txt Edit (2.7 KiB, text/plain; charset="utf-8")
JournalErrors.txt Edit (3.8 KiB, text/plain; charset="utf-8")
Lspci.txt Edit (131.5 KiB, text/plain; charset="utf-8")
ProcCpuinfo.txt Edit (29.7 KiB, text/plain; charset="utf-8")
ProcInterrupts.txt Edit (25.4 KiB, text/plain; charset="utf-8")
ProcModules.txt Edit (2.3 KiB, text/plain; charset="utf-8")
SystemdDelta.txt Edit (776 bytes, text/plain; charset="utf-8")
UdevDb.txt Edit (218.4 KiB, text/plain; charset="utf-8")

Revision history for this message

dino99 (9d9) wrote on 2015-05-05:

#2

Confirmed by lp:1442044 which also have dupe

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-05-05:

#3

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in systemd (Ubuntu):
status:	New → Confirmed

Revision history for this message

Martin Pitt (pitti) wrote on 2015-05-05:

#4

The LSB (http://refspecs.linuxbase.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/facilname.html) has never required to wait with calling rc.local until the network is up. After all, that might very well be "never", and this would both diminish the usefulness of rc.local as well as change existing behaviour. Or did you see some documentation which says otherwise?

If you need to run something after getting online, I suggest putting it into /etc/network/ifup.d/.

Changed in systemd (Ubuntu):
importance:	Undecided → Wishlist
status:	Confirmed → Incomplete

Revision history for this message

Dr. Jens Harbott (j-harbott) wrote on 2015-05-05:

#5

While I agree that this may never have been guaranteed, it has been working with all previous init systems. For me, the implied policy of using rc.local is: Run after all other init stuff has finished.

For example, https://github.com/puppetlabs/razor-server uses modifying rc.local in order to trigger some post installation actions to happen once the node has rebooted after being installed. This works pretty well with Precise and Trusty and also seems to be fine with most other distros.

Also, having a server with no network connectivity ever will also not be very useful. This is certainly different for desktop systems, but then, why would you have the

After=network.target

at all?

Changed in systemd (Ubuntu):
status:	Incomplete → New

Martin Pitt (pitti) on 2015-05-06

Changed in systemd (Ubuntu):
status:	New → Triaged
importance:	Wishlist → Low

Revision history for this message

Martin Pitt (pitti) wrote on 2015-06-01:

#6

http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=4a268404

Changed in systemd (Ubuntu):
assignee:	nobody → Martin Pitt (pitti)
status:	Triaged → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-06-10:

#7

Download full text (10.7 KiB)

This bug was fixed in the package systemd - 220-5ubuntu2

---------------
systemd (220-5ubuntu2) wily; urgency=medium

* boot-and-services: Drop expectedFailure from NSpawn.test_boot() test, this
seems to work properly now.

systemd (220-5ubuntu1) wily; urgency=medium

  * Merge with Debian unstable. Remaining Ubuntu changes:
    - Hack to support system-image read-only /etc, and modify files in
      /etc/writable/ instead.
    - Keep our much simpler udev maintainer scripts (all platforms must
      support udev, no debconf).
    - initramfs init-top: Drop scsi_wait_scan and udevadm settle, we do that
      in a more sensible way with wait-for-root.
    - initramfs init-bottom: If LVM is installed, settle udev,
      otherwise we get missing LV symlinks. Workaround for LP #1185394.
    - Add debian/udev.lvm2.init: Dummy SysV init script to satisfy insserv
      dependencies to "lvm2" which is handled with udev rules in Ubuntu.
    - Add debian/udev.lvm2.service to avoid running the dummy lvm2 init
      script.
    - Provide shutdown fallback for upstart. (LP: #1370329)
    - debian/extra/ifup@.service: Additionally run for "auto" class. We don't
      really support "allow-hotplug" in Ubuntu at the moment, so we need to
      deal with "auto" devices appearing after "/etc/init.d/networking start"
      already ran. (LP: #1374521) Also run ifup in the background during boot,
      to avoid blocking network.target. (LP: #1425376)
    - ifup@.service: Drop dependency on networking.service (i. e.
      /etc/init.d/networking), and merely ensure that /run/network exists.
      This avoids unnecessary dependencies/waiting during boot and dependency
      cycles if hooks wait for other interfaces to come up (like ifenslave
      with bonding interfaces). (LP: #1414544)
    - Add Get-RTC-is-in-local-time-setting-from-etc-default-rc.patch: In
      Ubuntu we currently keep the setting whether the RTC is in local or UTC
      time in /etc/default/rcS "UTC=yes|no", instead of /etc/adjtime.
      (LP: #1377258)
    - Put session scopes into all cgroup controllers. This makes unprivileged
      user LXC containers work under systemd. (LP: #1346734)
    - systemctl: Don't forward telinit u to upstart. This works around
      upstart's Restart() always reexec'ing /sbin/init on Restart(), even if
      that changes to point to systemd during the upgrade. This avoids running
      systemd during a dist-upgrade. (LP: #1430479)
    - Drop hwdb-update dependency from udev-trigger.service, which got
      introduced in v219-stable. This causes udev and plymouth to start too
      late and isn't really needed in Ubuntu yet as we don't support stateless
      systems yet and handle hwdb.bin updates through dpkg triggers. This can
      be dropped again with initramfs-tools 0.117.
    - Lower Breaks: to plymouth version which has the udev inotify fix in
      Ubuntu.
    - Lower apparmor Breaks: to the Ubuntu version that dropped $remote_fs.
    - Change systemd-sysv's conflicts to upstart-sysv. (LP: #1422681)
    - Make failure of boot-and-services NSpawn.test_boot non-fatal for now.
      This currently fails when being triggered by Jenkins, but is totall...

This bug was fixed in the package systemd - 220-5ubuntu2

---------------
systemd (220-5ubuntu2) wily; urgency=medium

* boot-and-services: Drop expectedFailure from NSpawn.test_boot() test, this
    seems to work properly now.

systemd (220-5ubuntu1) wily; urgency=medium

* Merge with Debian unstable. Remaining Ubuntu changes:
    - Hack to support system-image read-only /etc, and modify files in
      /etc/writable/ instead.
    - Keep our much simpler udev maintainer scripts (all platforms must
      support udev, no debconf).
    - initramfs init-top: Drop scsi_wait_scan and udevadm settle, we do that
      in a more sensible way with wait-for-root.
    - initramfs init-bottom: If LVM is installed, settle udev,
      otherwise we get missing LV symlinks. Workaround for LP #1185394.
    - Add debian/udev.lvm2.init: Dummy SysV init script to satisfy insserv
      dependencies to "lvm2" which is handled with udev rules in Ubuntu.
    - Add debian/udev.lvm2.service to avoid running the dummy lvm2 init
      script.
    - Provide shutdown fallback for upstart. (LP: #1370329)
    - debian/extra/ifup@.service: Additionally run for "auto" class. We don't
      really support "allow-hotplug" in Ubuntu at the moment, so we need to
      deal with "auto" devices appearing after "/etc/init.d/networking start"
      already ran. (LP: #1374521) Also run ifup in the background during boot,
      to avoid blocking network.target. (LP: #1425376)
    - ifup@.service: Drop dependency on networking.service (i. e.
      /etc/init.d/networking), and merely ensure that /run/network exists.
      This avoids unnecessary dependencies/waiting during boot and dependency
      cycles if hooks wait for other interfaces to come up (like ifenslave
      with bonding interfaces). (LP: #1414544)
    - Add Get-RTC-is-in-local-time-setting-from-etc-default-rc.patch: In
      Ubuntu we currently keep the setting whether the RTC is in local or UTC
      time in /etc/default/rcS "UTC=yes|no", instead of /etc/adjtime.
      (LP: #1377258)
    - Put session scopes into all cgroup controllers. This makes unprivileged
      user LXC containers work under systemd. (LP: #1346734)
    - systemctl: Don't forward telinit u to upstart. This works around
      upstart's Restart() always reexec'ing /sbin/init on Restart(), even if
      that changes to point to systemd during the upgrade. This avoids running
      systemd during a dist-upgrade. (LP: #1430479)
    - Drop hwdb-update dependency from udev-trigger.service, which got
      introduced in v219-stable. This causes udev and plymouth to start too
      late and isn't really needed in Ubuntu yet as we don't support stateless
      systems yet and handle hwdb.bin updates through dpkg triggers. This can
      be dropped again with initramfs-tools 0.117.
    - Lower Breaks: to plymouth version which has the udev inotify fix in
      Ubuntu.
    - Lower apparmor Breaks: to the Ubuntu version that dropped $remote_fs.
    - Change systemd-sysv's conflicts to upstart-sysv. (LP: #1422681)
    - Make failure of boot-and-services NSpawn.test_boot non-fatal for now.
      This currently fails when being triggered by Jenkins, but is totally
      unreproducible when running this manually on the exact same machine.

Upgrade fixes, keep until 16.04 LTS release:
    - systemd Conflicts/Replaces/Provides systemd-services.
    - Remove obsolete systemd-logind upstart job.
    - Clean up obsolete /etc/udev/rules.d/README.

systemd (220-5) unstable; urgency=medium

* debian/README.source: Upstream repository moved to github, adjust
    cherry-picking instructions accordingly.
  * debian/control: Replace obsolete Python2 version header with
    X-Python3-Version.
  * dracut: Fix path to systemd-fsck. (Closes: #787553)
  * Ignore test failures during build if /etc/machine-id is missing (which is
    the case in a few buildd chroots still). (Closes: #787258)
  * debian/udev.README.Debian: Move network interface hotplug documentation
    into separate section. Point out that "lo" does not need to be configured
    in ifupdown under systemd.
  * debian/udev.README.Debian: Document net.ifnames, and how to write udev
    rules for custom network names.
  * Add debian/extra/01-mac-for-usb.link: Use MAC based names for network
    interfaces which are (directly or indirectly) on USB. Path based names
    are inadequate for dynamic buses like USB.
  * Fix another escape parsing regression in Exec*= lines. (Closes: #787256)
  * Disable EFI support for udeb build.
  * Refine detection of touch screen devices.

systemd (220-4) unstable; urgency=medium

[ Martin Pitt ]
  * debian/extra/initramfs-tools/scripts/init-top/udev: Drop $ROOTDELAY wait.
    This does not concern udev in particular, but is handled by
    initramfs-tools itself (scripts/local). The intention of this parameter is
    not to statically wait for the given time, but wait *up to* that time for
    the root device to appear.
  * Add debian/extra/units/rc-local.service.d/wait-online.conf: Make
    rc-local.service wait for network-online.target (if it gets started). This
    not specified by LSB, but has been behaving that way in Debian under SysV
    init and upstart. (LP: #1451797)
  * Fix parsing of escape characters in Exec*= lines. (Closes: #787256)
  * Drop path_is_mount_point-handle-false-positive-on-some-fs.patch (it was
    already not applied in 220-1). This needs to be re-thought and re-done
    against the current code, and overlayfs in general. On overlayfs this
    still reports false positives for files that changed in the upperdir, but
    this does not break systemd-machine-id-commit any more.
  * Add debian/extra/rules/80-debian-compat.rules, replacing three of our
    patches. These are independent udev rules to change device permissions and
    add CD/DVD symlinks for compatibility with earlier Debian releases.

[ Michael Biebl ]
  * Bump Depends on util-linux to make sure we have a sulogin implementation
    which properly cleans up its children when emergency.service is restarted.
    (Closes: #784238)
  * Stop using /sbin/udevd and drop the compat symlink.
  * Remove any vestiges of /dev/.udev/. This directory has been replaced by
    /run/udev/ since wheezy.
  * Drop udev migration code from pre-wheezy.

systemd (220-3) unstable; urgency=medium

* Fix ProtectSystem=yes to actually protect /usr, not /home.
    (Closes: #787343)
  * sd-device: fix device_get_properties_strv(). Fixes environment for
    processes spawned by udev, in particular "allow-hoplug" ifupdown
    interfaces via ifup@.service. (Closes: #787263)
  * Ignore test failures on mipsel; the three failures are not reproducible on
    the porter box (different kernel?). (See #787258)
  * Add ifupdown-hotplug autopkgtest. Reproduces #787263.
  * udev: Bring back persistant storage symlinks for bcache. Thanks David
    Mohr! (Closes: #787367)
  * sd-device: Fix invalid property strv pointers. This unbreaks the
    environment of udev callouts.

systemd (220-2) unstable; urgency=low

* 220-1 was meant to go to experimental, but was accidentally uploaded to
    unstable. This was planned for next week anyway, just not on a Friday;
    we don't revert, but keep an RC bug open for a few days to get broader
    testing. Reupload 220-1 with its changelog actually pointing to unstable
    and with all versions in the .changes.

systemd (220-1) unstable; urgency=medium

[ Martin Pitt ]
  * New upstream release:
    - Ship sdio.ids and ids-update.pl in upstream tarball. (Closes: #780650)
    - Drop non-working "journalctl /dev/sda" example from manpage
      (Closes: #781604)
    - man systemd.network: Explain UseDomains a bit more (not used by
      default). (Closes: #766413)
    - Ignore comments in /etc/hostname (LP: #766413)
    - Drop all backported patches and port the others to new upstream release.
  * Cherry-pick patch to fix udevd --daemon assertion regression.
  * Cherry-pick patch to fix udevd worker hang.
  * systemd.install: systemd.pc moved back into /usr/share/pkgconfig/.
  * libsystemd0.symbols: Add new symbols from this release.
  * Drop debian/extra/60-keyboard.hwdb for now. Upstream has a newer version,
    and it's not nearly as often updated any more as it used to be.
  * debian/rules: Remove shipped audit_type-to-name.h and
    keyboard-keys-from-name.gperf and regenerate them during build (bug in
    upstream 220 tarball).
  * autopkgtest: Ship/use mock fsck from debian/tests, as it's missing in the
    220 tarball.
  * Add libnss-mymachines binary package. (Closes: #784858)
  * Add libnss-myhostname binary package, taking over from the very old and
    unmaintained standalone source package as per its maintainer's request.
    (Closes: #760514)
  * Drop buildsys-Don-t-default-to-gold-as-the-linker.patch and set LD in
    debian/rules on sparc only. This can be dropped entirely once we build
    GUdev from a separate source.
  * bootchart autopkgtest: Skip test if /proc/schedstat does not exist, i. e.
    the kernel is missing CONFIG_SCHEDSTAT. Bootchart requires this.
  * systemd-fsckd autopkgtest: On Debian plymouth-start stays running, adjust
    was_running() for that.
  * systemd-fsckd autopkgtest: In test_systemd_fsck_with_plymouth_failure(),
    fix plymouthd status check to work under both Debian and Ubuntu.
  * Replace almost all of Fix-paths-in-man-pages.patch with upstreamed
    patches. (The reminder is planned to get fixed upstream as well.)
  * Remove our update-rc.d patches, replace them with upstream patches for
    /lib/systemd/systemd-sysv-install abstraction, and provide one for
    update-rc.d. Also implement "is-enabled" command by directly checking for
    the presence of rcS or rc5 symlinks. (Closes: #760616)
  * Fix path_is_mount_point for files (regression in 220).
  * debian/control: Drop obsolete XS-Testsuite:, dpkg adds it automatically.
  * Use Ubuntu's default NTP server for timesyncd when building on Ubuntu.

[ Michael Biebl ]
  * Remove /var/run and /var/lock migration code from debian-fixup. The /run
    migration was completed in wheezy so this is no longer necessary.
  * Drop our versioned Depends on initscripts. This was initially added for
    the /run migration and later to ensure we have a mountnfs hook which
    doesn't cause a deadlock under systemd. The /run migration was completed
    in wheezy and jessie ships a fixed mountnfs hook. In addition we now use
    the ignore-dependencies job mode in our lsb init-functions hook, so it's
    safe to drop this dependency.
  * Stop building gudev packages. Upstream has moved the gudev code into a
    separate repository which is now managed on gnome.org. The gudev packages
    will be built from src:libgudev from now on. See also
    http://lists.freedesktop.org/archives/systemd-devel/2015-May/032070.html

-- Martin Pitt <martin.pitt@ubuntu.com>  Wed, 10 Jun 2015 09:01:16 +0200

Changed in systemd (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Steve Dodd (anarchetic) wrote on 2021-11-14:

#8

This commit actually didn't reliably fix this bug, but given the length of time here, I've opened a new bug #1950906

Ubuntu
systemd package

rc.local should require network-online.target

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntusystemd package

rc.local should require network-online.target

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
systemd package